Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 24657003: GN: Return array from pkgconfig wrapper (Closed)

Created:
7 years, 2 months ago by brettw
Modified:
7 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

GN: Return array from pkgconfig wrapper This changes the pkg-config wrapper to support filtering out values (we'll need this for some NSS stuff which will be in a followup patch) and parsing and returning the results in a GN array in one go, rather than requiring two invocations. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225274

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1

Patch Set 3 : includes #

Patch Set 4 : empty list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -21 lines) Patch
M tools/gn/secondary/build/config/linux/BUILD.gn View 1 2 2 chunks +24 lines, -16 lines 0 comments Download
M tools/gn/secondary/build/config/linux/pkg-config.py View 1 2 3 1 chunk +66 lines, -1 line 0 comments Download
M tools/gn/secondary/crypto/ssl/BUILD.gn View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M tools/gn/secondary/third_party/nss/BUILD.gn View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
7 years, 2 months ago (2013-09-25 21:23:46 UTC) #1
scottmg
I kind of liked the "don't touch it", are you sure autoquoting isn't going to ...
7 years, 2 months ago (2013-09-25 21:30:52 UTC) #2
brettw
I reverted the escaping change. I was getting worried about this when Nico was asking ...
7 years, 2 months ago (2013-09-25 21:34:56 UTC) #3
scottmg
lgtm https://codereview.chromium.org/24657003/diff/5001/tools/gn/secondary/build/config/linux/pkg-config.py File tools/gn/secondary/build/config/linux/pkg-config.py (right): https://codereview.chromium.org/24657003/diff/5001/tools/gn/secondary/build/config/linux/pkg-config.py#newcode66 tools/gn/secondary/build/config/linux/pkg-config.py:66: # Output a GN array, the first one ...
7 years, 2 months ago (2013-09-25 21:47:41 UTC) #4
brettw
7 years, 2 months ago (2013-09-25 23:07:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r225274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698