Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 2465623002: Add chrome namespace to chrome/common/network_diagnostics.mojom (Closed)

Created:
4 years, 1 month ago by nigeltao1
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome namespace to chrome/common/network_diagnostics.mojom BUG= Committed: https://crrev.com/c4802d1ed85722f8999e392f41470de8f12e40f0 Cr-Commit-Position: refs/heads/master@{#429777}

Patch Set 1 #

Patch Set 2 : Add chrome namespace to chrome/common/network_diagnostics.mojom #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M chrome/browser/net/net_error_tab_helper.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/net/net_error_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/net_error_tab_helper_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/network_diagnostics.mojom View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/net/net_error_helper.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/net/net_error_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
nigeltao1
4 years, 1 month ago (2016-10-29 04:31:03 UTC) #8
sky
LGTM
4 years, 1 month ago (2016-10-31 15:08:45 UTC) #11
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-10-31 15:58:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465623002/20001
4 years, 1 month ago (2016-11-02 22:59:10 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/295420)
4 years, 1 month ago (2016-11-02 23:09:32 UTC) #16
nigeltao1
tsepez, can you review for chrome/common/OWNERS?
4 years, 1 month ago (2016-11-02 23:36:15 UTC) #18
Tom Sepez
OWNERS LGTM for mojom
4 years, 1 month ago (2016-11-03 17:54:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465623002/20001
4 years, 1 month ago (2016-11-03 22:45:57 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 03:52:30 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 03:55:24 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4802d1ed85722f8999e392f41470de8f12e40f0
Cr-Commit-Position: refs/heads/master@{#429777}

Powered by Google App Engine
This is Rietveld 408576698