Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2465603002: [Extensions] Don't show a blocked action for webRequest on subframes (Closed)

Created:
4 years, 1 month ago by Devlin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Don't show a blocked action for webRequest on subframes Click-To-Script blocks webRequest on sites without permission, but we currently don't have any mechanism of granting subframe origins. As such, we don't count blocking subframe actions as a reason to show the blocked action indicator in the case of content scripts running on subframes. We should do the same for webRequest actions. BUG=660901 Committed: https://crrev.com/eb53f1445275265a2b81112a69a5205004b709d3 Cr-Commit-Position: refs/heads/master@{#428787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -12 lines) Patch
M chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 7 chunks +49 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Devlin
Antony, can you take a look?
4 years, 1 month ago (2016-10-31 17:53:42 UTC) #7
asargent_no_longer_on_chrome
lgtm
4 years, 1 month ago (2016-10-31 18:46:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465603002/1
4 years, 1 month ago (2016-10-31 19:04:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 20:27:18 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 20:29:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb53f1445275265a2b81112a69a5205004b709d3
Cr-Commit-Position: refs/heads/master@{#428787}

Powered by Google App Engine
This is Rietveld 408576698