Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Issue 24656002: [webcrypto] Add decrypt() for AES-CBC. (Closed)

Created:
7 years, 2 months ago by eroman
Modified:
7 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Bryan Eyler
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : Chang CHECK --> DCHECK #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : re-upload after revert #

Patch Set 6 : Check for empty decryption input #

Patch Set 7 : Dont do &vector[0] for empty vectors #

Patch Set 8 : return NULL instead of 1 when empty #

Patch Set 9 : Also reject non-block aligned inputs #

Patch Set 10 : reword "non-block-aligned" to "not a multiple of block size" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -57 lines) Patch
M content/renderer/webcrypto/webcrypto_impl.h View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_nss.cc View 1 2 3 4 5 6 7 8 9 4 chunks +49 lines, -11 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_openssl.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M content/renderer/webcrypto/webcrypto_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 14 chunks +108 lines, -46 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
eroman
Depends on the other CLs I already mailed out.
7 years, 2 months ago (2013-09-25 20:22:23 UTC) #1
Ryan Sleevi
lgtm https://codereview.chromium.org/24656002/diff/1/content/renderer/webcrypto_impl_unittest.cc File content/renderer/webcrypto_impl_unittest.cc (right): https://codereview.chromium.org/24656002/diff/1/content/renderer/webcrypto_impl_unittest.cc#newcode504 content/renderer/webcrypto_impl_unittest.cc:504: EXPECT_FALSE(DecryptInternal(CreateAesCbcAlgorithm(iv), This reminds me: There should be a ...
7 years, 2 months ago (2013-09-25 20:36:13 UTC) #2
eroman
https://codereview.chromium.org/24656002/diff/1/content/renderer/webcrypto_impl_unittest.cc File content/renderer/webcrypto_impl_unittest.cc (right): https://codereview.chromium.org/24656002/diff/1/content/renderer/webcrypto_impl_unittest.cc#newcode504 content/renderer/webcrypto_impl_unittest.cc:504: EXPECT_FALSE(DecryptInternal(CreateAesCbcAlgorithm(iv), On 2013/09/25 20:36:14, Ryan Sleevi wrote: > This ...
7 years, 2 months ago (2013-09-25 20:39:13 UTC) #3
Ryan Sleevi
https://codereview.chromium.org/24656002/diff/1/content/renderer/webcrypto_impl_unittest.cc File content/renderer/webcrypto_impl_unittest.cc (right): https://codereview.chromium.org/24656002/diff/1/content/renderer/webcrypto_impl_unittest.cc#newcode504 content/renderer/webcrypto_impl_unittest.cc:504: EXPECT_FALSE(DecryptInternal(CreateAesCbcAlgorithm(iv), On 2013/09/25 20:39:13, eroman wrote: > On 2013/09/25 ...
7 years, 2 months ago (2013-09-25 20:41:05 UTC) #4
eroman
jamesr or jochen for content/renderer approval.
7 years, 2 months ago (2013-09-25 20:46:29 UTC) #5
jamesr
Would it make sense to set up a subdirectory for y'all with your own OWNERS ...
7 years, 2 months ago (2013-09-25 21:29:03 UTC) #6
eroman
> Would it make sense to set up a subdirectory for y'all with > your ...
7 years, 2 months ago (2013-09-25 22:11:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24656002/28001
7 years, 2 months ago (2013-09-27 10:58:05 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=82262
7 years, 2 months ago (2013-09-27 12:11:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24656002/28001
7 years, 2 months ago (2013-09-27 16:46:33 UTC) #10
eroman
Committed patchset #4 manually as r225743 (presubmit successful).
7 years, 2 months ago (2013-09-27 18:25:47 UTC) #11
eroman
I reverted this because of a valgrind error [1]. rsleevi: Please review the fix added ...
7 years, 2 months ago (2013-09-27 22:04:29 UTC) #12
eroman
rsleevi: I updated the unittests to remove instances of &vector[0] on empty vectors, PTAL.
7 years, 2 months ago (2013-09-27 23:59:50 UTC) #13
Ryan Sleevi
lgtm
7 years, 2 months ago (2013-09-28 00:47:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24656002/70001
7 years, 2 months ago (2013-09-28 00:50:30 UTC) #15
eroman
Note that I generalized the check to reject any AES_BLOCK_SIZE aligned decryption input, since they ...
7 years, 2 months ago (2013-09-28 18:05:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24656002/75001
7 years, 2 months ago (2013-09-30 16:49:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24656002/84001
7 years, 2 months ago (2013-09-30 17:09:38 UTC) #18
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-09-30 23:38:02 UTC) #19
eroman
7 years, 2 months ago (2013-10-01 00:43:12 UTC) #20
Message was sent while issue was closed.
Committed patchset #10 manually as r226092 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698