Chromium Code Reviews| Index: src/debug/debug.cc |
| diff --git a/src/debug/debug.cc b/src/debug/debug.cc |
| index b3d8347cfd32171d95b40b55b3703532bfa46d37..675200fb9a86936f1f80dbcea69a65905c431d96 100644 |
| --- a/src/debug/debug.cc |
| +++ b/src/debug/debug.cc |
| @@ -1352,6 +1352,86 @@ bool Debug::PrepareFunctionForBreakPoints(Handle<SharedFunctionInfo> shared) { |
| return true; |
| } |
| +namespace { |
| +template <typename Iterator> |
| +void GetBreakablePositions(Iterator& it, int start_position, int end_position, |
|
Yang
2016/11/04 12:22:58
The iterator is still passed by &-reference.
kozy
2016/11/04 14:48:38
Done.
|
| + BreakPositionAlignment alignment, |
| + std::vector<int>* positions) { |
| + it.SkipToPosition(start_position, alignment); |
| + while (!it.Done() && it.position() < end_position && |
| + it.position() >= start_position) { |
| + positions->push_back(alignment == STATEMENT_ALIGNED |
| + ? it.statement_position() |
| + : it.position()); |
| + it.Next(); |
| + } |
| +} |
| + |
| +void FindBreakablePositions(Handle<DebugInfo> debug_info, int start_position, |
| + int end_position, BreakPositionAlignment alignment, |
| + std::vector<int>* positions) { |
| + if (debug_info->HasDebugCode()) { |
| + CodeBreakIterator it(debug_info, ALL_BREAK_LOCATIONS); |
| + GetBreakablePositions(it, start_position, end_position, alignment, |
| + positions); |
| + } else { |
| + DCHECK(debug_info->HasDebugBytecodeArray()); |
| + BytecodeArrayBreakIterator it(debug_info, ALL_BREAK_LOCATIONS); |
| + GetBreakablePositions(it, start_position, end_position, alignment, |
| + positions); |
| + } |
| +} |
| +} // namespace |
| + |
| +bool Debug::GetPossibleBreakpoints(Handle<Script> script, int start_position, |
| + int end_position, |
| + std::vector<int>* positions) { |
| + while (true) { |
| + if (!script->shared_function_infos()->IsWeakFixedArray()) return false; |
| + |
| + WeakFixedArray* infos = |
| + WeakFixedArray::cast(script->shared_function_infos()); |
| + HandleScope scope(isolate_); |
| + List<Handle<SharedFunctionInfo>> candidates; |
| + { |
| + WeakFixedArray::Iterator iterator(infos); |
| + SharedFunctionInfo* info; |
| + while ((info = iterator.Next<SharedFunctionInfo>())) { |
| + if (info->end_position() < start_position || |
| + info->start_position() >= end_position) { |
| + continue; |
| + } |
| + if (!info->IsSubjectToDebugging()) continue; |
| + if (!info->HasDebugCode() && !info->allows_lazy_compilation()) continue; |
| + candidates.Add(i::handle(info)); |
| + } |
| + } |
| + |
| + bool was_compiled = false; |
| + for (int i = 0; i < candidates.length(); ++i) { |
| + if (!candidates[i]->HasDebugCode()) { |
| + if (!Compiler::CompileDebugCode(candidates[i])) { |
| + return false; |
| + } else { |
| + was_compiled = true; |
| + } |
| + } |
| + if (!candidates[i]->HasDebugInfo()) CreateDebugInfo(candidates[i]); |
| + } |
| + if (was_compiled) continue; |
| + |
| + for (int i = 0; i < candidates.length(); ++i) { |
| + CHECK(candidates[i]->HasDebugInfo()); |
| + Handle<DebugInfo> debug_info(candidates[i]->GetDebugInfo()); |
| + FindBreakablePositions(debug_info, start_position, end_position, |
| + STATEMENT_ALIGNED, positions); |
| + } |
| + return true; |
| + } |
| + UNREACHABLE(); |
| + return false; |
| +} |
| + |
| void Debug::RecordAsyncFunction(Handle<JSGeneratorObject> generator_object) { |
| if (last_step_action() <= StepOut) return; |
| if (!IsAsyncFunction(generator_object->function()->shared()->kind())) return; |