Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2465543002: [MacViews] Left-align control labels as on other platforms. (Closed)

Created:
4 years, 1 month ago by shrike
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MacViews] Left-align control labels as on other platforms. The Harmony spec calls for left-aligned control labels. Labels are correctly aligned on Windows but not on the Mac because of special-case code. This cl removes that special-case code to bring the Mac in line with all other platforms. R=sky@chromium.org BUG=660578 Committed: https://crrev.com/106d55c0f1e8b3a074565392d13b9f528deba61a Cr-Commit-Position: refs/heads/master@{#428552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ui/views/layout/layout_constants.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 1 month ago (2016-10-28 22:58:33 UTC) #1
sky
LGTM
4 years, 1 month ago (2016-10-28 23:08:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465543002/1
4 years, 1 month ago (2016-10-28 23:09:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-29 00:10:51 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-29 00:44:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/106d55c0f1e8b3a074565392d13b9f528deba61a
Cr-Commit-Position: refs/heads/master@{#428552}

Powered by Google App Engine
This is Rietveld 408576698