Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2465493002: build_scan: Fix exception handling (Closed)

Created:
4 years, 1 month ago by martiniss
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move exception logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M scripts/slave/build_scan.py View 1 3 chunks +11 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
martiniss
PTAL
4 years, 1 month ago (2016-10-28 20:18:11 UTC) #2
ghost stip (do not use)
https://codereview.chromium.org/2465493002/diff/1/scripts/slave/build_scan.py File scripts/slave/build_scan.py (right): https://codereview.chromium.org/2465493002/diff/1/scripts/slave/build_scan.py#newcode164 scripts/slave/build_scan.py:164: try: put this in _url_open_json() instead
4 years, 1 month ago (2016-10-28 20:34:01 UTC) #3
martiniss
https://codereview.chromium.org/2465493002/diff/1/scripts/slave/build_scan.py File scripts/slave/build_scan.py (right): https://codereview.chromium.org/2465493002/diff/1/scripts/slave/build_scan.py#newcode164 scripts/slave/build_scan.py:164: try: On 2016/10/28 at 20:34:01, stip wrote: > put ...
4 years, 1 month ago (2016-10-28 20:42:29 UTC) #4
ghost stip (do not use)
lgtm
4 years, 1 month ago (2016-10-28 21:06:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465493002/20001
4 years, 1 month ago (2016-10-28 21:44:16 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 21:55:34 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/b67196c320e6a97c67e0...

Powered by Google App Engine
This is Rietveld 408576698