Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2763)

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2465433002: Create implementation of the side panel using a dialog. (Closed)
Patch Set: Feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_ui/settings_ui.js
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js
index b009c069e0f49e6f7fcaf3316fd5dabd0061faa5..9438be7ebb1cc36a5170bfe22f25a9531eb5fb7d 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js
@@ -72,13 +72,12 @@ Polymer({
*/
ready: function() {
// Lazy-create the drawer the first time it is opened or swiped into view.
- var drawer = assert(this.$$('app-drawer'));
- listenOnce(drawer, 'track opened-changed', function() {
+ listenOnce(this.$.drawer, 'open-changed', function() {
this.$.drawerTemplate.if = true;
}.bind(this));
window.addEventListener('popstate', function(e) {
- drawer.close();
+ this.$.drawer.close();
}.bind(this));
if (loadTimeData.getBoolean('isGuest')) {
@@ -169,17 +168,17 @@ Polymer({
*/
onIronActivate_: function(event) {
if (event.detail.item.id != 'advancedPage')
- this.$$('app-drawer').close();
+ this.$.drawer.close();
},
/** @private */
onMenuButtonTap_: function() {
- this.$$('app-drawer').toggle();
+ this.$.drawer.toggle();
},
/** @private */
directionDelegateChanged_: function() {
- this.$$('app-drawer').align = this.directionDelegate.isRtl() ?
+ this.$.drawer.align = this.directionDelegate.isRtl() ?
'right' : 'left';
},
});

Powered by Google App Engine
This is Rietveld 408576698