Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 246543007: Fix the Array.push simulate for non-effect context. (Closed)

Created:
6 years, 8 months ago by Jarin
Modified:
6 years, 8 months ago
Reviewers:
danno-g, danno
CC:
v8-dev
Visibility:
Public.

Description

Fix the Array.push simulate for non-effect context. R=danno@google.com, danno@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/hydrogen.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/array-push11.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno-g
lgtm
6 years, 8 months ago (2014-04-23 14:16:00 UTC) #1
Jarin
6 years, 8 months ago (2014-04-23 14:27:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r20912 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698