Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: client/third_party/infra_libs/event_mon/monitoring.py

Issue 2465423002: Roll infra_libs to 564aaf7480f24c90687df79d9cef910cc342a54d (Closed)
Patch Set: update readmes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/third_party/infra_libs/event_mon/monitoring.py
diff --git a/client/third_party/infra_libs/event_mon/monitoring.py b/client/third_party/infra_libs/event_mon/monitoring.py
index 5a16b0e2bc7deaad9952711e7191edb580925801..dd90c51ef9d9f6df0372cc6eec01fc288c9cf130 100644
--- a/client/third_party/infra_libs/event_mon/monitoring.py
+++ b/client/third_party/infra_libs/event_mon/monitoring.py
@@ -183,11 +183,6 @@ def _get_service_event(event_type,
version = event.service_event.code_version.add()
version.source_url = version_d['source_url']
if 'revision' in version_d:
- # Rely on the url to switch between svn and git because an
- # abbreviated sha1 can sometimes be confused with an int.
- if version.source_url.startswith('svn://'):
- version.svn_revision = int(version_d['revision'])
- else:
version.git_hash = version_d['revision']
if 'version' in version_d:
@@ -233,7 +228,7 @@ def send_service_event(event_type,
code_version (list/tuple of dict or None): required keys are
'source_url' -> full url to the repository
- 'revision' -> (string) git sha1 or svn revision number.
+ 'revision' -> (string) git sha1
optional keys are
'dirty' -> boolean. True if the local source tree has local
modification.
@@ -356,7 +351,6 @@ def get_build_event(event_type,
if head_revision_git_hash:
event.build_event.head_revision.git_hash = head_revision_git_hash
-
if event.build_event.step_name:
if event_type != 'STEP':

Powered by Google App Engine
This is Rietveld 408576698