Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2202)

Unified Diff: ash/common/system/tray/tray_item_view.h

Issue 2465403002: Some more fixes to cros system tray icons (esp. screen tray items) (Closed)
Patch Set: commentary Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/tray/tray_item_view.h
diff --git a/ash/common/system/tray/tray_item_view.h b/ash/common/system/tray/tray_item_view.h
index a590a8cebb4b53e440a7a52cbe93888a24ef9e0b..c56a0730ceba8013fbf0c86661bb2391dc76f5ba 100644
--- a/ash/common/system/tray/tray_item_view.h
+++ b/ash/common/system/tray/tray_item_view.h
@@ -36,6 +36,7 @@ class ASH_EXPORT TrayItemView : public views::View,
static void DisableAnimationsForTest();
// Convenience function for creating a child Label or ImageView.
+ // Only one of the two should be called.
void CreateLabel();
void CreateImageView();
@@ -67,6 +68,7 @@ class ASH_EXPORT TrayItemView : public views::View,
SystemTrayItem* owner_;
std::unique_ptr<gfx::SlideAnimation> animation_;
+ // Only one of |label_| and |image_view_| should be non-null.
views::Label* label_;
views::ImageView* image_view_;
« no previous file with comments | « ash/common/system/chromeos/screen_security/screen_tray_item.cc ('k') | ash/common/system/tray/tray_item_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698