Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2465373002: [Devtools] Fix network timeline canvas selection splitview (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 WebInspector.NetworkLogViewColumns = class { 7 WebInspector.NetworkLogViewColumns = class {
8 /** 8 /**
9 * @param {!WebInspector.NetworkLogView} networkLogView 9 * @param {!WebInspector.NetworkLogView} networkLogView
10 * @param {!WebInspector.NetworkTransferTimeCalculator} timeCalculator 10 * @param {!WebInspector.NetworkTransferTimeCalculator} timeCalculator
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 if (!Runtime.experiments.isEnabled('canvasNetworkTimeline')) 428 if (!Runtime.experiments.isEnabled('canvasNetworkTimeline'))
429 return; 429 return;
430 // TODO(allada) Move this code into the code above. 430 // TODO(allada) Move this code into the code above.
431 if (gridMode) { 431 if (gridMode) {
432 this._splitWidget.showBoth(); 432 this._splitWidget.showBoth();
433 this._activeScroller = this._timelineScroller; 433 this._activeScroller = this._timelineScroller;
434 this._timelineScroller.scrollTop = this._dataGridScroller.scrollTop; 434 this._timelineScroller.scrollTop = this._dataGridScroller.scrollTop;
435 this._dataGridScroller.style.overflow = 'hidden'; 435 this._dataGridScroller.style.overflow = 'hidden';
436 this._dataGrid.setScrollContainer(this._timelineScroller); 436 this._dataGrid.setScrollContainer(this._timelineScroller);
437 } else { 437 } else {
438 this._splitWidget.hideMain(); 438 this._splitWidget.hideSidebar();
439 this._activeScroller = this._dataGridScroller; 439 this._activeScroller = this._dataGridScroller;
440 this._dataGridScroller.style.overflow = 'overlay'; 440 this._dataGridScroller.style.overflow = 'overlay';
441 this._dataGrid.setScrollContainer(this._dataGridScroller); 441 this._dataGrid.setScrollContainer(this._dataGridScroller);
442 } 442 }
443 } 443 }
444 444
445 /** 445 /**
446 * @param {!WebInspector.NetworkLogViewColumns.Descriptor} columnConfig 446 * @param {!WebInspector.NetworkLogViewColumns.Descriptor} columnConfig
447 */ 447 */
448 _toggleColumnVisibility(columnConfig) { 448 _toggleColumnVisibility(columnConfig) {
(...skipping 622 matching lines...) Expand 10 before | Expand all | Expand 10 after
1071 */ 1071 */
1072 WebInspector.NetworkLogViewColumns.TimelineSortIds = { 1072 WebInspector.NetworkLogViewColumns.TimelineSortIds = {
1073 StartTime: 'startTime', 1073 StartTime: 'startTime',
1074 ResponseTime: 'responseReceivedTime', 1074 ResponseTime: 'responseReceivedTime',
1075 EndTime: 'endTime', 1075 EndTime: 'endTime',
1076 Duration: 'duration', 1076 Duration: 'duration',
1077 Latency: 'latency' 1077 Latency: 'latency'
1078 }; 1078 };
1079 1079
1080 1080
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698