Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by allada Modified:
4 years, 1 month ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Fix network timeline canvas selection splitview
This patch fixes a regression caused when a user selects a request
in the new network canvas timeline it would show the canvas to the left
instead of the name column.
R=dgozman
BUG=653738
Committed: https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d
Committed: https://crrev.com/a8ce2ab11cbe520868896bfc52ca72e3e25e2165
Cr-Original-Commit-Position: refs/heads/master@{#429092}
Cr-Commit-Position: refs/heads/master@{#429150}
Patch Set 1 #Patch Set 2 : changes #
Created: 4 years, 1 month ago
Messages
Total messages: 21 (12 generated)
The CQ bit was checked by allada@chromium.org to run a CQ dry run
PTL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by pfeldman@chromium.org
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2472523002/ by pfeldman@chromium.org. The reason for reverting is: I'll reapply it..
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fix network timeline canvas selection splitview This patch fixes a regression caused when a user selects a request in the new network canvas timeline it would show the canvas to the left instead of the name column. R=dgozman BUG=653738 ========== to ========== [Devtools] Fix network timeline canvas selection splitview This patch fixes a regression caused when a user selects a request in the new network canvas timeline it would show the canvas to the left instead of the name column. R=dgozman BUG=653738 Committed: https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d Cr-Commit-Position: refs/heads/master@{#429092} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d Cr-Commit-Position: refs/heads/master@{#429092}
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fix network timeline canvas selection splitview This patch fixes a regression caused when a user selects a request in the new network canvas timeline it would show the canvas to the left instead of the name column. R=dgozman BUG=653738 Committed: https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d Cr-Commit-Position: refs/heads/master@{#429092} ========== to ========== [Devtools] Fix network timeline canvas selection splitview This patch fixes a regression caused when a user selects a request in the new network canvas timeline it would show the canvas to the left instead of the name column. R=dgozman BUG=653738 Committed: https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d Cr-Commit-Position: refs/heads/master@{#429092} ==========
The CQ bit was checked by allada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2465373002/#ps20001 (title: "changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fix network timeline canvas selection splitview This patch fixes a regression caused when a user selects a request in the new network canvas timeline it would show the canvas to the left instead of the name column. R=dgozman BUG=653738 Committed: https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d Cr-Commit-Position: refs/heads/master@{#429092} ========== to ========== [Devtools] Fix network timeline canvas selection splitview This patch fixes a regression caused when a user selects a request in the new network canvas timeline it would show the canvas to the left instead of the name column. R=dgozman BUG=653738 Committed: https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d Cr-Commit-Position: refs/heads/master@{#429092} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fix network timeline canvas selection splitview This patch fixes a regression caused when a user selects a request in the new network canvas timeline it would show the canvas to the left instead of the name column. R=dgozman BUG=653738 Committed: https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d Cr-Commit-Position: refs/heads/master@{#429092} ========== to ========== [Devtools] Fix network timeline canvas selection splitview This patch fixes a regression caused when a user selects a request in the new network canvas timeline it would show the canvas to the left instead of the name column. R=dgozman BUG=653738 Committed: https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d Committed: https://crrev.com/a8ce2ab11cbe520868896bfc52ca72e3e25e2165 Cr-Original-Commit-Position: refs/heads/master@{#429092} Cr-Commit-Position: refs/heads/master@{#429150} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a8ce2ab11cbe520868896bfc52ca72e3e25e2165 Cr-Commit-Position: refs/heads/master@{#429150} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
