Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Side by Side Diff: third_party/WebKit/Source/modules/sensor/SensorProxy.cpp

Issue 2465363004: [Sensors] Consider maximum supported frequency (Closed)
Patch Set: Comment from Tim Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/sensor/SensorProxy.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/sensor/SensorProxy.h" 5 #include "modules/sensor/SensorProxy.h"
6 6
7 #include "core/frame/LocalFrame.h" 7 #include "core/frame/LocalFrame.h"
8 #include "modules/sensor/SensorProviderProxy.h" 8 #include "modules/sensor/SensorProviderProxy.h"
9 #include "modules/sensor/SensorReading.h" 9 #include "modules/sensor/SensorReading.h"
10 #include "platform/mojo/MojoHelper.h" 10 #include "platform/mojo/MojoHelper.h"
11 #include "public/platform/Platform.h" 11 #include "public/platform/Platform.h"
12 12
13 using namespace device::mojom::blink; 13 using namespace device::mojom::blink;
14 14
15 namespace blink { 15 namespace blink {
16 16
17 SensorProxy::SensorProxy(SensorType sensorType, 17 SensorProxy::SensorProxy(SensorType sensorType,
18 SensorProviderProxy* provider, 18 SensorProviderProxy* provider,
19 std::unique_ptr<SensorReadingFactory> readingFactory) 19 std::unique_ptr<SensorReadingFactory> readingFactory)
20 : m_type(sensorType), 20 : m_type(sensorType),
21 m_mode(ReportingMode::CONTINUOUS), 21 m_mode(ReportingMode::CONTINUOUS),
22 m_provider(provider), 22 m_provider(provider),
23 m_clientBinding(this), 23 m_clientBinding(this),
24 m_state(SensorProxy::Uninitialized), 24 m_state(SensorProxy::Uninitialized),
25 m_suspended(false), 25 m_suspended(false),
26 m_readingFactory(std::move(readingFactory)) {} 26 m_readingFactory(std::move(readingFactory)),
27 m_maximumFrequency(0.0) {}
27 28
28 SensorProxy::~SensorProxy() {} 29 SensorProxy::~SensorProxy() {}
29 30
30 void SensorProxy::dispose() { 31 void SensorProxy::dispose() {
31 m_clientBinding.Close(); 32 m_clientBinding.Close();
32 } 33 }
33 34
34 DEFINE_TRACE(SensorProxy) { 35 DEFINE_TRACE(SensorProxy) {
35 visitor->trace(m_reading); 36 visitor->trace(m_reading);
36 visitor->trace(m_observers); 37 visitor->trace(m_observers);
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 m_sharedBufferHandle = std::move(params->memory); 174 m_sharedBufferHandle = std::move(params->memory);
174 DCHECK(!m_sharedBuffer); 175 DCHECK(!m_sharedBuffer);
175 m_sharedBuffer = 176 m_sharedBuffer =
176 m_sharedBufferHandle->MapAtOffset(kReadBufferSize, params->buffer_offset); 177 m_sharedBufferHandle->MapAtOffset(kReadBufferSize, params->buffer_offset);
177 178
178 if (!m_sharedBuffer) { 179 if (!m_sharedBuffer) {
179 handleSensorError(); 180 handleSensorError();
180 return; 181 return;
181 } 182 }
182 183
184 m_maximumFrequency = params->maximum_frequency;
185 DCHECK(m_maximumFrequency <= SensorConfiguration::kMaxAllowedFrequency);
186
183 auto errorCallback = 187 auto errorCallback =
184 WTF::bind(&SensorProxy::handleSensorError, wrapWeakPersistent(this), 188 WTF::bind(&SensorProxy::handleSensorError, wrapWeakPersistent(this),
185 UnknownError, String("Internal error"), String()); 189 UnknownError, String("Internal error"), String());
186 m_sensor.set_connection_error_handler( 190 m_sensor.set_connection_error_handler(
187 convertToBaseCallback(std::move(errorCallback))); 191 convertToBaseCallback(std::move(errorCallback)));
188 192
189 m_state = Initialized; 193 m_state = Initialized;
190 for (Observer* observer : m_observers) 194 for (Observer* observer : m_observers)
191 observer->onSensorInitialized(); 195 observer->onSensorInitialized();
192 } 196 }
193 197
194 bool SensorProxy::tryReadFromBuffer(device::SensorReading& result) { 198 bool SensorProxy::tryReadFromBuffer(device::SensorReading& result) {
195 DCHECK(isInitialized()); 199 DCHECK(isInitialized());
196 const ReadingBuffer* buffer = 200 const ReadingBuffer* buffer =
197 static_cast<const ReadingBuffer*>(m_sharedBuffer.get()); 201 static_cast<const ReadingBuffer*>(m_sharedBuffer.get());
198 const device::OneWriterSeqLock& seqlock = buffer->seqlock.value(); 202 const device::OneWriterSeqLock& seqlock = buffer->seqlock.value();
199 auto version = seqlock.ReadBegin(); 203 auto version = seqlock.ReadBegin();
200 auto readingData = buffer->reading; 204 auto readingData = buffer->reading;
201 if (seqlock.ReadRetry(version)) 205 if (seqlock.ReadRetry(version))
202 return false; 206 return false;
203 result = readingData; 207 result = readingData;
204 return true; 208 return true;
205 } 209 }
206 210
207 } // namespace blink 211 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/sensor/SensorProxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698