Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2465363003: Improve how the column balancer handles top margins on floats. (Closed)
Patch Set: Back out some unnecessary changes that caused assertion failures in a test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h
index c2f91e860f112e43f4dfc09b3648791de5e93a0a..10a78c5c175ae143b329c8de53b72f7579658642 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h
@@ -251,7 +251,10 @@ class CORE_EXPORT LayoutBox : public LayoutBoxModelObject {
return style()->isHorizontalWritingMode() ? m_frameRect.height()
: m_frameRect.width();
}
- LayoutUnit logicalHeightIncludingOverflow() const;
+
+ // Logical height of the object, including content overflowing the
+ // border-after edge.
+ LayoutUnit logicalHeightWithVisibleOverflow() const;
LayoutUnit constrainLogicalWidthByMinMax(LayoutUnit,
LayoutUnit,

Powered by Google App Engine
This is Rietveld 408576698