third_party/WebKit/Source/core/layout/LayoutBox.h - Issue 2465363003: Improve how the column balancer handles top margins on floats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2465363003: Improve how the column balancer handles top margins on floats. (Closed)

Patch Set: Back out some unnecessary changes that caused assertion failures in a test. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h

index c2f91e860f112e43f4dfc09b3648791de5e93a0a..10a78c5c175ae143b329c8de53b72f7579658642 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h

@@ -251,7 +251,10 @@ class CORE_EXPORT LayoutBox : public LayoutBoxModelObject {

return style()->isHorizontalWritingMode() ? m_frameRect.height()

: m_frameRect.width();

}

- LayoutUnit logicalHeightIncludingOverflow() const;

+ // Logical height of the object, including content overflowing the

+ // border-after edge.

+ LayoutUnit logicalHeightWithVisibleOverflow() const;

LayoutUnit constrainLogicalWidthByMinMax(LayoutUnit,

LayoutUnit,