third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html - Issue 2465363003: Improve how the column balancer handles top margins on floats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html

Issue 2465363003: Improve how the column balancer handles top margins on floats. (Closed)

Patch Set: Back out some unnecessary changes that caused assertion failures in a test. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html

diff --git a/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html b/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html

new file mode 100644

index 0000000000000000000000000000000000000000..e2a6bd98183ac72a0b221941e5d7ec4afc7a575a

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-after-break-2.html

@@ -0,0 +1,21 @@

+<!DOCTYPE html>

+<p>There should be a cyan square in the bottom right corner of a blue rectangle.</p>

+<div id="multicol" style="position:relative; columns:3; line-height:20px; orphans:1; widows:1; background:blue;">

+ <br>

+ <div id="elm" style="float:right; margin-top:30px; width:40px; line-height:40px; background:cyan;">

+ <br>

+ </div>

+</div>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script>

+test(() => {

+ var multicol = document.getElementById("multicol");

+ var elm = document.getElementById("elm");

+ assert_equals(multicol.offsetHeight, 70);

+ assert_equals(elm.offsetTop, 30);

+}, "Float that should fit its top margin together with the border box.");

+</script>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ColumnBalancer.h » ('j') | third_party/WebKit/Source/core/layout/ColumnBalancer.cpp » ('J')