Chromium Code Reviews
DescriptionReland of command buffer: audit validation of ES3 commands (part 1) (patchset #1 id:1 of https://codereview.chromium.org/2470663003/ )
Reason for revert:
The revert did not fix the interacitve_ui_test flake.
Failed build after the revert:
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8542
Original issue's description:
> Revert of command buffer: audit validation of ES3 commands (part 1) (patchset #2 id:20001 of https://codereview.chromium.org/2458523005/ )
>
> Reason for revert:
> Speculative revert for interacitve_ui_test flakes on mac.
>
> First failed build:
> https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8412
>
> Original issue's description:
> > command buffer: audit validation of ES3 commands (part 1)
> >
> > Audit the validation (safety) of the first few ES3 command buffer commands - and switch the gating from 'unsafe_es3_apis_enabled()' to 'feature_info_->IsWebGL2OrES3Context' on newly audited commands.
> >
> > BUG=654787
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/6e51299d296d504fb450dcdbb1814427cd62248f
> > Cr-Commit-Position: refs/heads/master@{#428499}
>
> TBR=zmo@chromium.org,kainino@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=654787
>
> Committed: https://crrev.com/c2ba95c8151deb3fcb1690e44c71c038af0a3627
> Cr-Commit-Position: refs/heads/master@{#428999}
TBR=zmo@chromium.org,kainino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=654787
Committed: https://crrev.com/bde232fe70fe8c2e0943ed05c31210d70b4cd8de
Cr-Commit-Position: refs/heads/master@{#429029}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||