Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 246533003: Make find_used_resources.py output resource ids in numerical order. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make find_used_resources.py output resource ids in numerical order. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265472

Patch Set 1 #

Patch Set 2 : add deps file #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/resources/find_used_resources.py View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
6 years, 8 months ago (2014-04-22 04:47:50 UTC) #1
Lei Zhang
And roll DEPS for grit-i18n
6 years, 8 months ago (2014-04-23 01:00:35 UTC) #2
aurimas (slooooooooow)
https://codereview.chromium.org/246533003/diff/20001/DEPS File DEPS (right): https://codereview.chromium.org/246533003/diff/20001/DEPS#newcode137 DEPS:137: (Var("googlecode_url") % "grit-i18n") + "/trunk@167", It is being rolled ...
6 years, 8 months ago (2014-04-23 01:01:56 UTC) #3
Lei Zhang
On 2014/04/23 01:01:56, aurimas wrote: > https://codereview.chromium.org/246533003/diff/20001/DEPS > File DEPS (right): > > https://codereview.chromium.org/246533003/diff/20001/DEPS#newcode137 > ...
6 years, 8 months ago (2014-04-23 01:04:43 UTC) #4
aurimas (slooooooooow)
lgtm
6 years, 8 months ago (2014-04-23 01:09:24 UTC) #5
Lei Zhang
Whoops, I meant to roll DEPS in the other CL. Oh well. That turned into ...
6 years, 8 months ago (2014-04-23 01:11:26 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-23 01:11:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/246533003/40001
6 years, 8 months ago (2014-04-23 01:12:55 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 01:34:27 UTC) #9
Message was sent while issue was closed.
Change committed as 265472

Powered by Google App Engine
This is Rietveld 408576698