Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: components/cronet/ios/test/cronet_netlog_test.mm

Issue 2465303002: [cronet] make startNetLogToFile write to correct file (Closed)
Patch Set: sync Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/ios/test/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/ios/test/cronet_netlog_test.mm
diff --git a/components/cronet/ios/test/cronet_netlog_test.mm b/components/cronet/ios/test/cronet_netlog_test.mm
new file mode 100644
index 0000000000000000000000000000000000000000..03766ec649fea8c7da15b00cfc193d20131cf98b
--- /dev/null
+++ b/components/cronet/ios/test/cronet_netlog_test.mm
@@ -0,0 +1,94 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <Cronet/Cronet.h>
+#import <Foundation/Foundation.h>
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace cronet {
+
+void StartCronetIfNecessary();
+
+class NetLogTest : public ::testing::Test {
+ protected:
+ NetLogTest() {}
+ ~NetLogTest() override {}
+
+ void SetUp() override { StartCronetIfNecessary(); }
+};
+
+TEST(NetLogTest, OpenFile) {
+ bool netlog_started =
+ [Cronet startNetLogToFile:@"cronet_netlog.json" logBytes:YES];
+ [Cronet stopNetLog];
+
+ EXPECT_TRUE(netlog_started);
+}
+
+TEST(NetLogTest, CreateFile) {
+ NSString* filename = [[[NSProcessInfo processInfo] globallyUniqueString]
+ stringByAppendingString:@"_netlog.json"];
+ bool netlog_started = [Cronet startNetLogToFile:filename logBytes:YES];
+ [Cronet stopNetLog];
+
+ bool file_created = [[NSFileManager defaultManager]
+ fileExistsAtPath:[Cronet getNetLogPathForFile:filename]];
+
+ [[NSFileManager defaultManager]
+ removeItemAtPath:[Cronet getNetLogPathForFile:filename]
+ error:nil];
+
+ EXPECT_TRUE(netlog_started);
+ EXPECT_TRUE(file_created);
+}
+
+TEST(NetLogTest, NonExistantDir) {
+ NSString* notdir = [[[NSProcessInfo processInfo] globallyUniqueString]
+ stringByAppendingString:@"/netlog.json"];
+ bool netlog_started = [Cronet startNetLogToFile:notdir logBytes:NO];
+
+ EXPECT_FALSE(netlog_started);
+}
+
+TEST(NetLogTest, ExistantDir) {
+ NSString* dir = [[NSProcessInfo processInfo] globallyUniqueString];
+
+ bool dir_created = [[NSFileManager defaultManager]
+ createDirectoryAtPath:[Cronet getNetLogPathForFile:dir]
+ withIntermediateDirectories:NO
+ attributes:nil
+ error:nil];
+
+ bool netlog_started =
+ [Cronet startNetLogToFile:[dir stringByAppendingString:@"/netlog.json"]
+ logBytes:NO];
+
+ [[NSFileManager defaultManager]
+ removeItemAtPath:[Cronet
+ getNetLogPathForFile:
+ [dir stringByAppendingString:@"/netlog.json"]]
+ error:nil];
+
+ [[NSFileManager defaultManager]
+ removeItemAtPath:[Cronet getNetLogPathForFile:dir]
+ error:nil];
+
+ EXPECT_TRUE(dir_created);
+ EXPECT_TRUE(netlog_started);
+}
+
+TEST(NetLogTest, EmptyFilename) {
+ bool netlog_started = [Cronet startNetLogToFile:@"" logBytes:NO];
+
+ EXPECT_FALSE(netlog_started);
+}
+
+TEST(NetLogTest, AbsoluteFilename) {
+ bool netlog_started =
+ [Cronet startNetLogToFile:@"/home/netlog.json" logBytes:NO];
+
+ EXPECT_FALSE(netlog_started);
+}
+}
« no previous file with comments | « components/cronet/ios/test/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698