Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: components/cronet/ios/cronet_environment.h

Issue 2465303002: [cronet] make startNetLogToFile write to correct file (Closed)
Patch Set: sync Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/ios/Cronet.mm ('k') | components/cronet/ios/cronet_environment.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/ios/cronet_environment.h
diff --git a/components/cronet/ios/cronet_environment.h b/components/cronet/ios/cronet_environment.h
index 874afb0901b5ef0b4d955bb431b657d29eb5f28e..fbcb74d84def55e3d1dc5e4c521ab330ebf8f332 100644
--- a/components/cronet/ios/cronet_environment.h
+++ b/components/cronet/ios/cronet_environment.h
@@ -10,6 +10,7 @@
#include <vector>
#include "base/files/file_path.h"
+#include "base/files/scoped_file.h"
#include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/sys_string_conversions.h"
@@ -57,7 +58,7 @@ class CronetEnvironment {
// Creates a new net log (overwrites existing file with this name). If
// actively logging, this call is ignored.
- void StartNetLog(base::FilePath::StringType file_name, bool log_bytes);
+ bool StartNetLog(base::FilePath::StringType file_name, bool log_bytes);
// Stops logging and flushes file. If not currently logging this call is
// ignored.
void StopNetLog();
@@ -111,8 +112,7 @@ class CronetEnvironment {
const base::Closure& task);
// Helper methods that start/stop net logging on the network thread.
- void StartNetLogOnNetworkThread(const base::FilePath::StringType& file_name,
- bool log_bytes);
+ void StartNetLogOnNetworkThread(base::ScopedFILE file, bool log_bytes);
void StopNetLogOnNetworkThread(base::WaitableEvent* log_stopped_event);
// Returns the HttpNetworkSession object from the passed in
« no previous file with comments | « components/cronet/ios/Cronet.mm ('k') | components/cronet/ios/cronet_environment.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698