Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: components/cronet/ios/cronet_environment.h

Issue 2465303002: [cronet] make startNetLogToFile write to correct file (Closed)
Patch Set: per #15 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/ios/cronet_environment.h
diff --git a/components/cronet/ios/cronet_environment.h b/components/cronet/ios/cronet_environment.h
index 87fc862318c0aeaeee6feeed6f1d773c5f2c7166..87546ecc762dcbc2261714f13b969d5d393d687d 100644
--- a/components/cronet/ios/cronet_environment.h
+++ b/components/cronet/ios/cronet_environment.h
@@ -10,6 +10,7 @@
#include <vector>
#include "base/files/file_path.h"
+#include "base/files/scoped_file.h"
#include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/synchronization/waitable_event.h"
@@ -59,7 +60,7 @@ class CronetEnvironment {
// Creates a new net log (overwrites existing file with this name). If
// actively logging, this call is ignored.
- void StartNetLog(base::FilePath::StringType file_name, bool log_bytes);
+ bool StartNetLog(base::FilePath::StringType file_name, bool log_bytes);
// Stops logging and flushes file. If not currently logging this call is
// ignored.
void StopNetLog();
@@ -108,8 +109,7 @@ class CronetEnvironment {
const base::Closure& task);
// Helper methods that start/stop net logging on the network thread.
- void StartNetLogOnNetworkThread(const base::FilePath::StringType& file_name,
- bool log_bytes);
+ void StartNetLogOnNetworkThread(base::ScopedFILE file, bool log_bytes);
void StopNetLogOnNetworkThread(base::WaitableEvent* log_stopped_event);
// Returns the HttpNetworkSession object from the passed in

Powered by Google App Engine
This is Rietveld 408576698