[cronet] make startNetLogToFile write to correct file

components/cronet/ios/Cronet.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "components/cronet/ios/Cronet.h"
 
 #include <memory>
 
 #include "base/lazy_instance.h"
 #include "base/logging.h"
@@ skipping 215 matching lines @@
     [NSURLCache setSharedURLCache:gPreservedSharedURLCache];
     gPreservedSharedURLCache = nil;
   }
   [NSURLProtocol unregisterClass:[CRNPauseableHTTPProtocolHandler class]];
 }
 
 + (void)installIntoSessionConfiguration:(NSURLSessionConfiguration*)config {
   config.protocolClasses = @[ [CRNPauseableHTTPProtocolHandler class] ];
 }
 
-+ (void)startNetLogToFile:(NSString*)fileName logBytes:(BOOL)logBytes {
++ (BOOL)startNetLogToFile:(NSString*)fileName logBytes:(BOOL)logBytes {
   if (gChromeNet.Get().get() && [fileName length]) {
-    gChromeNet.Get()->StartNetLog([fileName UTF8String], logBytes);
+    NSURL* file =
+        [[[[NSFileManager defaultManager] URLsForDirectory:NSDocumentDirectory
+                                                 inDomains:NSUserDomainMask]
+            lastObject] URLByAppendingPathComponent:fileName];

[kapishnikov, 2016/11/18 22:17:27]

The documentation of the method implies that absolute path is supported. What
will be the value of |file| if the absolute path is passed?

[lilyhoughton, 2016/11/22 20:48:42]

This is a documentation error.  (Absolute path is supported for the internal cpp
function, but not the Obj-C wrapper).

+    return gChromeNet.Get()->StartNetLog(base::SysNSStringToUTF8([file path]),
+                                         logBytes);
   }
+
+  return NO;
 }
 
 + (void)stopNetLog {
   if (gChromeNet.Get().get()) {
     gChromeNet.Get()->StopNetLog();
   }
 }
 
 + (NSString*)getUserAgent {
   if (!gChromeNet.Get().get()) {
@@ skipping 30 matching lines @@
   gHostResolverRulesForTesting = hostResolverRulesForTesting;
 }
 
 // This is a non-public dummy method that prevents the linker from stripping out
 // the otherwise non-referenced methods from 'cronet_bidirectional_stream.cc'.
 + (void)preventStrippingCronetBidirectionalStream {
   cronet_bidirectional_stream_create(NULL, 0, 0);
 }
 
 @end