[cronet] make startNetLogToFile write to correct file

components/cronet/ios/test/cronet_netlog_test.mm

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <Cronet/Cronet.h>
+#import <Foundation/Foundation.h>
+
+#include "base/logging.h"
+#include "base/mac/scoped_nsobject.h"
+#include "base/strings/sys_string_conversions.h"
+#include "components/cronet/ios/test/quic_test_server.h"
+#include "components/cronet/ios/test/test_server.h"
+#include "net/base/mac/url_conversions.h"
+#include "net/base/net_errors.h"
+#include "net/cert/mock_cert_verifier.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "testing/gtest_mac.h"
+

[mef, 2016/11/10 17:09:48]

nit: no need for empty line.

[lilyhoughton, 2016/11/16 16:04:10]

Done.

+#include "url/gurl.h"
+
+namespace cronet {
+
+void StartCronetIfNecessary();
+
+TEST(NetLogTest, OpenFile) {
+  StartCronetIfNecessary();

[mef, 2016/11/10 17:09:49]

Not having to repeat boiler-plate code (StartCronetIfNecessary)  seems like a
good reason to have a Test class.

[lilyhoughton, 2016/11/16 16:04:10]

Done.

+
+  bool res = [Cronet startNetLogToFile:@"cronet_netlog.json" logBytes:YES];
+  [Cronet stopNetLog];
+
+  EXPECT_TRUE(res);
+}
+
+TEST(NetLogTest, NonExistantDir) {
+  StartCronetIfNecessary();
+
+  NSString* notdir = [[[NSProcessInfo processInfo] globallyUniqueString]
+      stringByAppendingString:@"/netlog.json"];
+  bool res = [Cronet startNetLogToFile:notdir logBytes:NO];
+
+  EXPECT_FALSE(res);
+}
+
+TEST(NetLogTest, EmptyFilename) {
+  StartCronetIfNecessary();
+
+  bool res = [Cronet startNetLogToFile:@"" logBytes:NO];
+
+  EXPECT_FALSE(res);
+}
+}