Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/dom/scripts/systemhtml.py

Issue 24653006: Adding Element.created constructor (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Adding createCallback to custom_element.dart Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tests/html/custom/attribute_changed_callback_test.dart ('K') | « tests/html/html.status ('k') | tools/dom/src/dart2js_CustomElementSupport.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/systemhtml.py
diff --git a/tools/dom/scripts/systemhtml.py b/tools/dom/scripts/systemhtml.py
index 7c5ec1274a8b519b87e50207eac29d73d2025506..740b79f680e2b7cc384310e8b9668e7d6e8e9022 100644
--- a/tools/dom/scripts/systemhtml.py
+++ b/tools/dom/scripts/systemhtml.py
@@ -593,6 +593,20 @@ class HtmlDartInterfaceGenerator(object):
self._backend.AddConstructors(
constructors, factory_provider, factory_constructor_name)
+ isElement = False
+ for parent in self._database.Hierarchy(self._interface):
+ if parent.id == 'Element':
+ isElement = True
+ if isElement and self._interface.id != 'Element':
+ self._implementation_members_emitter.Emit(
+ ' /**\n'
+ ' * Constructor instantiated by the DOM when a custom element has been created.\n'
+ ' *\n'
+ ' * This can only be called by subclasses from their created constructor.\n'
+ ' */\n'
+ ' $CLASSNAME.created(): super.created();\n',
sra1 2013/10/01 02:37:04 created() : super.created()
blois 2013/10/01 16:36:19 Done.
+ CLASSNAME=self._interface_type_info.implementation_name())
+
self._backend.EmitSupportCheck()
merged_interface = self._interface_type_info.merged_interface()
« tests/html/custom/attribute_changed_callback_test.dart ('K') | « tests/html/html.status ('k') | tools/dom/src/dart2js_CustomElementSupport.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698