Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Unified Diff: src/objects.h

Issue 2465283004: [modules] Maintain array of cells for imports and local exports. (Closed)
Patch Set: Various changes. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 2c3860d906ca7f297cdb87b3f346349b8d878582..35d70e6e69eb323a0759b34f9dc7caba20b6b3dd 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -8179,6 +8179,9 @@ class Module : public Struct {
// The export table.
adamk 2016/11/03 18:30:45 This comment could be further fleshed out too (e.g
neis 2016/11/04 10:14:39 Done.
DECL_ACCESSORS(exports, ObjectHashTable)
+ DECL_ACCESSORS(regular_exports, FixedArray)
adamk 2016/11/03 18:30:45 Comments for these? Especially since "exports" and
neis 2016/11/04 10:14:39 Done.
+ DECL_ACCESSORS(regular_imports, FixedArray)
+
// Hash for this object (a random non-zero Smi).
DECL_INT_ACCESSORS(hash)
@@ -8207,12 +8210,9 @@ class Module : public Struct {
// Implementation of spec operation ModuleEvaluation.
static MUST_USE_RESULT MaybeHandle<Object> Evaluate(Handle<Module> module);
- static Handle<Object> LoadExport(Handle<Module> module, Handle<String> name);
- static void StoreExport(Handle<Module> module, Handle<String> name,
- Handle<Object> value);
-
- static Handle<Object> LoadImport(Handle<Module> module, Handle<String> name,
- int module_request);
+ static Handle<Object> LoadVariable(Handle<Module> module, int index);
+ static void StoreVariable(Handle<Module> module, int index,
+ Handle<Object> value);
// Get the namespace object for [module_request] of [module]. If it doesn't
// exist yet, it is created.
@@ -8221,7 +8221,9 @@ class Module : public Struct {
static const int kCodeOffset = HeapObject::kHeaderSize;
static const int kExportsOffset = kCodeOffset + kPointerSize;
- static const int kHashOffset = kExportsOffset + kPointerSize;
+ static const int kRegularExportsOffset = kExportsOffset + kPointerSize;
+ static const int kRegularImportsOffset = kRegularExportsOffset + kPointerSize;
+ static const int kHashOffset = kRegularImportsOffset + kPointerSize;
static const int kModuleNamespaceOffset = kHashOffset + kPointerSize;
static const int kRequestedModulesOffset =
kModuleNamespaceOffset + kPointerSize;
@@ -8230,7 +8232,8 @@ class Module : public Struct {
private:
enum { kEvaluatedBit };
- static void CreateExport(Handle<Module> module, Handle<FixedArray> names);
+ static void CreateExport(Handle<Module> module, int index,
+ Handle<FixedArray> names);
static void CreateIndirectExport(Handle<Module> module, Handle<String> name,
Handle<ModuleInfoEntry> entry);

Powered by Google App Engine
This is Rietveld 408576698