Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2465283003: bluetooth: Add logging for peripheral events on mac (Closed)

Created:
4 years, 1 month ago by ortuno
Modified:
4 years, 1 month ago
Reviewers:
scheib
CC:
chromium-reviews, mac-reviews_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Add logging for peripheral events on mac Sometimes users have problems with the API and the lack of logging has made it difficult to pinpoint the issue. BUG=659608 Committed: https://crrev.com/61b7c1766f78c2577d85a8cb4442d6df791bf8ad Cr-Commit-Position: refs/heads/master@{#429508}

Patch Set 1 #

Patch Set 2 : Fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 6 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
ortuno
scheib: PTAL
4 years, 1 month ago (2016-11-02 05:49:27 UTC) #4
scheib
LGTM
4 years, 1 month ago (2016-11-03 01:20:38 UTC) #9
ortuno
Thanks!
4 years, 1 month ago (2016-11-03 01:35:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465283003/20001
4 years, 1 month ago (2016-11-03 01:36:15 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 01:57:10 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 02:00:09 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/61b7c1766f78c2577d85a8cb4442d6df791bf8ad
Cr-Commit-Position: refs/heads/master@{#429508}

Powered by Google App Engine
This is Rietveld 408576698