Always store the type of a conditional expression on the node.

Always store the type of a conditional expressions on the node.

Previously, the type of a conditional expression could be omitted if
one of the arms was just a null literal. This was meant to simplify
translation into kernel, but wasn't really worth it in terms of
complexity, and it does not work well for types that carry nullability
information.

BUG=
R=ahe@google.com

Committed: https://github.com/dart-lang/kernel/commit/c227e785a14e04f1688d75ad4d0f12b0be6b850f

[asgerf, 2016-11-01 12:33:26]

Description was changed from

==========
Always store the type of a conditional expressions on the node.

Previously, the type of a conditional expression could be omitted if
one of the arms was just a null literal. This was meant to simplify
translation into kernel, but wasn's really worth it in terms of
complexity, and it does not work well for types that carry nullability
information.

BUG=
==========

to

==========
Always store the type of a conditional expressions on the node.

Previously, the type of a conditional expression could be omitted if
one of the arms was just a null literal. This was meant to simplify
translation into kernel, but wasn't really worth it in terms of
complexity, and it does not work well for types that carry nullability
information.

BUG=
==========

[asgerf, 2016-11-01 13:43:19]

asgerf@google.com changed reviewers:
+ kmillikin@google.com

[ahe, 2016-11-01 13:45:00]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2016-11-01 13:45:00]

lgtm

https://codereview.chromium.org/2465263002/diff/1/testcases/input/null_aware....
File testcases/input/null_aware.dart (right):

https://codereview.chromium.org/2465263002/diff/1/testcases/input/null_aware....
testcases/input/null_aware.dart:1: class Foo {
No copyright.

[asgerf, 2016-11-01 14:34:49]

https://codereview.chromium.org/2465263002/diff/1/testcases/input/null_aware....
File testcases/input/null_aware.dart (right):

https://codereview.chromium.org/2465263002/diff/1/testcases/input/null_aware....
testcases/input/null_aware.dart:1: class Foo {
On 2016/11/01 13:45:00, ahe wrote:
> No copyright.

Done.

[asgerf, 2016-11-01 15:04:15]

Description was changed from

==========
Always store the type of a conditional expressions on the node.

Previously, the type of a conditional expression could be omitted if
one of the arms was just a null literal. This was meant to simplify
translation into kernel, but wasn't really worth it in terms of
complexity, and it does not work well for types that carry nullability
information.

BUG=
==========

to

==========
Always store the type of a conditional expressions on the node.

Previously, the type of a conditional expression could be omitted if
one of the arms was just a null literal. This was meant to simplify
translation into kernel, but wasn't really worth it in terms of
complexity, and it does not work well for types that carry nullability
information.

BUG=
R=ahe@google.com

Committed:
https://github.com/dart-lang/kernel/commit/c227e785a14e04f1688d75ad4d0f12b0be...
==========

[asgerf, 2016-11-01 15:04:17]

Committed patchset #5 (id:80001) manually as
c227e785a14e04f1688d75ad4d0f12b0be6b850f (presubmit successful).