src/crankshaft/x64/lithium-codegen-x64.cc - Issue 2465253011: Fastpath some spread-call desugaring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 2465253011: Fastpath some spread-call desugaring. (Closed)

Patch Set: Use functions for testing initial_* objects Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/x64/lithium-codegen-x64.cc

diff --git a/src/crankshaft/x64/lithium-codegen-x64.cc b/src/crankshaft/x64/lithium-codegen-x64.cc

index 52cf25175fe3ff44ceb77524371468999655bdea..aa2bc87aeb084eea0253f2ec3ac1ba9cefdae7cb 100644

--- a/src/crankshaft/x64/lithium-codegen-x64.cc

+++ b/src/crankshaft/x64/lithium-codegen-x64.cc

@@ -2828,7 +2828,7 @@ void LCodeGen::DoLoadKeyedFixedArray(LLoadKeyed* instr) {

// it needs to bail out.

__ LoadRoot(result, Heap::kArrayProtectorRootIndex);

__ Cmp(FieldOperand(result, Cell::kValueOffset),

- Smi::FromInt(Isolate::kArrayProtectorValid));

+ Smi::FromInt(Isolate::kProtectorValid));

DeoptimizeIf(not_equal, instr, DeoptimizeReason::kHole);

}

__ Move(result, isolate()->factory()->undefined_value());