src/crankshaft/arm/lithium-codegen-arm.cc - Issue 2465253011: Fastpath some spread-call desugaring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/arm/lithium-codegen-arm.cc

Issue 2465253011: Fastpath some spread-call desugaring. (Closed)

Patch Set: Use functions for testing initial_* objects Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/arm/lithium-codegen-arm.cc

diff --git a/src/crankshaft/arm/lithium-codegen-arm.cc b/src/crankshaft/arm/lithium-codegen-arm.cc

index d6eb69a6fd1fdf4d21fb9be8c846a38fb87afd0a..56b0577a02d59391f8940c6e81ab9556519f772b 100644

--- a/src/crankshaft/arm/lithium-codegen-arm.cc

+++ b/src/crankshaft/arm/lithium-codegen-arm.cc

@@ -2876,7 +2876,7 @@ void LCodeGen::DoLoadKeyedFixedArray(LLoadKeyed* instr) {

// it needs to bail out.

__ LoadRoot(result, Heap::kArrayProtectorRootIndex);

__ ldr(result, FieldMemOperand(result, Cell::kValueOffset));

- __ cmp(result, Operand(Smi::FromInt(Isolate::kArrayProtectorValid)));

+ __ cmp(result, Operand(Smi::FromInt(Isolate::kProtectorValid)));

DeoptimizeIf(ne, instr, DeoptimizeReason::kHole);

}

__ LoadRoot(result, Heap::kUndefinedValueRootIndex);