Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/crankshaft/ia32/lithium-codegen-ia32.cc

Issue 2465253011: Fastpath some spread-call desugaring. (Closed)
Patch Set: Handles double arrays too Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h" 7 #include "src/crankshaft/ia32/lithium-codegen-ia32.h"
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2607 matching lines...) Expand 10 before | Expand all | Expand 10 after
2618 __ cmp(result, factory()->the_hole_value()); 2618 __ cmp(result, factory()->the_hole_value());
2619 DeoptimizeIf(equal, instr, DeoptimizeReason::kHole); 2619 DeoptimizeIf(equal, instr, DeoptimizeReason::kHole);
2620 } 2620 }
2621 } else if (instr->hydrogen()->hole_mode() == CONVERT_HOLE_TO_UNDEFINED) { 2621 } else if (instr->hydrogen()->hole_mode() == CONVERT_HOLE_TO_UNDEFINED) {
2622 DCHECK(instr->hydrogen()->elements_kind() == FAST_HOLEY_ELEMENTS); 2622 DCHECK(instr->hydrogen()->elements_kind() == FAST_HOLEY_ELEMENTS);
2623 Label done; 2623 Label done;
2624 __ cmp(result, factory()->the_hole_value()); 2624 __ cmp(result, factory()->the_hole_value());
2625 __ j(not_equal, &done); 2625 __ j(not_equal, &done);
2626 if (info()->IsStub()) { 2626 if (info()->IsStub()) {
2627 // A stub can safely convert the hole to undefined only if the array 2627 // A stub can safely convert the hole to undefined only if the array
2628 // protector cell contains (Smi) Isolate::kArrayProtectorValid. 2628 // protector cell contains (Smi) Isolate::kProtectorValid.
2629 // Otherwise it needs to bail out. 2629 // Otherwise it needs to bail out.
2630 __ LoadRoot(result, Heap::kArrayProtectorRootIndex); 2630 __ LoadRoot(result, Heap::kArrayProtectorRootIndex);
2631 __ cmp(FieldOperand(result, PropertyCell::kValueOffset), 2631 __ cmp(FieldOperand(result, PropertyCell::kValueOffset),
2632 Immediate(Smi::FromInt(Isolate::kArrayProtectorValid))); 2632 Immediate(Smi::FromInt(Isolate::kProtectorValid)));
2633 DeoptimizeIf(not_equal, instr, DeoptimizeReason::kHole); 2633 DeoptimizeIf(not_equal, instr, DeoptimizeReason::kHole);
2634 } 2634 }
2635 __ mov(result, isolate()->factory()->undefined_value()); 2635 __ mov(result, isolate()->factory()->undefined_value());
2636 __ bind(&done); 2636 __ bind(&done);
2637 } 2637 }
2638 } 2638 }
2639 2639
2640 2640
2641 void LCodeGen::DoLoadKeyed(LLoadKeyed* instr) { 2641 void LCodeGen::DoLoadKeyed(LLoadKeyed* instr) {
2642 if (instr->is_fixed_typed_array()) { 2642 if (instr->is_fixed_typed_array()) {
(...skipping 2505 matching lines...) Expand 10 before | Expand all | Expand 10 after
5148 __ bind(deferred->exit()); 5148 __ bind(deferred->exit());
5149 __ bind(&done); 5149 __ bind(&done);
5150 } 5150 }
5151 5151
5152 #undef __ 5152 #undef __
5153 5153
5154 } // namespace internal 5154 } // namespace internal
5155 } // namespace v8 5155 } // namespace v8
5156 5156
5157 #endif // V8_TARGET_ARCH_IA32 5157 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698