Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2465253010: Add WebView PlzNavigate related fixes to extensions_browsertests harness. (Closed)

Created:
4 years, 1 month ago by jam
Modified:
4 years, 1 month ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WebView PlzNavigate related fixes to extensions_browsertests harness. This fixes AppViewTests_AppViewTest.TestAppViewMediaRequest_0 AppViewTests_AppViewTest.TestAppViewMediaRequest_1 WebViewAPITest.TestDeclarativeWebRequestAPI WebViewAPITest.TestDeclarativeWebRequestAPISendMessage WebViewAPITest.TestInlineScriptFromAccessibleResources WebViewAPITest.TestLoadAbortChromeExtensionURLWrongPartition WebViewAPITest.TestWebRequestAPI WebViewAPITest.TestWebRequestAPIGoogleProperty WebViewAPITest.TestWebRequestAPIWithHeaders with PlzNavigate. BUG=661812 Committed: https://crrev.com/039ca692b53631e5dd193bc40784baab3d6f9870 Cr-Commit-Position: refs/heads/master@{#429936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -20 lines) Patch
M extensions/shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_content_browser_client.h View 1 chunk +5 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_content_browser_client.cc View 3 chunks +18 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 3 chunks +16 lines, -0 lines 0 comments Download
A + extensions/shell/browser/shell_navigation_ui_data.h View 2 chunks +14 lines, -18 lines 0 comments Download
A extensions/shell/browser/shell_navigation_ui_data.cc View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jam
4 years, 1 month ago (2016-11-04 15:01:54 UTC) #9
Fady Samuel
lgtm
4 years, 1 month ago (2016-11-04 17:26:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465253010/20001
4 years, 1 month ago (2016-11-04 17:27:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-04 17:36:46 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 17:47:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/039ca692b53631e5dd193bc40784baab3d6f9870
Cr-Commit-Position: refs/heads/master@{#429936}

Powered by Google App Engine
This is Rietveld 408576698