Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2465253008: Fix quad convexity with only one backward dir (Closed)

Created:
4 years, 1 month ago by liyuqian
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix quad convexity with only one backward dir BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2465253008 Committed: https://skia.googlesource.com/skia/+/bdabcc4cb873dc4de39263c995900a05e6a32cf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/core/SkPath.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/PathTest.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
liyuqian
Please check the convexity fix. Without the fix, the added unit test would fail.
4 years, 1 month ago (2016-11-03 18:07:43 UTC) #4
caryclark
4 years, 1 month ago (2016-11-03 18:11:16 UTC) #8
caryclark
lgtm
4 years, 1 month ago (2016-11-03 18:38:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465253008/1
4 years, 1 month ago (2016-11-03 18:39:26 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 18:40:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bdabcc4cb873dc4de39263c995900a05e6a32cf4

Powered by Google App Engine
This is Rietveld 408576698