Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 246523006: Force a second video to exit fullscreen (Closed)

Created:
6 years, 8 months ago by David Trainor- moved to gerrit
Modified:
6 years, 7 months ago
Reviewers:
Ted C, qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, avayvod+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

On Android, force a subsequent fullscreen video to exit if another one is already playing. BUG=361550 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266673

Patch Set 1 #

Patch Set 2 : Added destructor check for safety #

Patch Set 3 : Removed duplicate code #

Patch Set 4 : Made second video exit #

Patch Set 5 : Removed unnecessary change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/browser/media/android/browser_media_player_manager.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
David Trainor- moved to gerrit
ptal!
6 years, 8 months ago (2014-04-24 19:44:04 UTC) #1
Ted C
lgtm
6 years, 8 months ago (2014-04-24 19:45:37 UTC) #2
qinmin
shouldn't we prevent the 2nd video from going fullscreen rather than asking the first one ...
6 years, 8 months ago (2014-04-24 20:38:40 UTC) #3
David Trainor- moved to gerrit
Addressed Min's comment and made the second video exit. Thanks for the tip! ptal
6 years, 8 months ago (2014-04-26 00:38:18 UTC) #4
qinmin
lgtm
6 years, 8 months ago (2014-04-26 00:45:46 UTC) #5
David Trainor- moved to gerrit
The CQ bit was checked by dtrainor@chromium.org
6 years, 7 months ago (2014-04-28 17:58:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/246523006/80001
6 years, 7 months ago (2014-04-28 18:03:42 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 22:24:39 UTC) #8
Message was sent while issue was closed.
Change committed as 266673

Powered by Google App Engine
This is Rietveld 408576698