Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2465223003: Don't abort the MimeHandlerStreamManager stream if we receive a RenderProcessHostChanged notificati… (Closed)

Created:
4 years, 1 month ago by ananta
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Don't abort the MimeHandlerStreamManager stream if we receive a RenderProcessHostChanged notification for a null old host. Merging to M55 This indicates that a subframe is being created. If we ignore the old_host here and set the new host pointer in the MimeHandlerStreamManager::EmbedderObserver class, this causes the stream to be aborted prematurely leading to embedded PDFs not loading. This should fix bug 650985 BUG=650985 Review-Url: https://codereview.chromium.org/2418963002 Cr-Commit-Position: refs/heads/master@{#425498} (cherry picked from commit b8cfa3b172b2741635247a8541e3251688aaa04f) Committed: https://chromium.googlesource.com/chromium/src/+/e7dac575925f858b0b344798e776c859f7c6076b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ananta
4 years, 1 month ago (2016-11-01 19:32:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e7dac575925f858b0b344798e776c859f7c6076b.

Powered by Google App Engine
This is Rietveld 408576698