Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2465163004: Support both older and newer implementations of dart:async. (Closed)

Created:
4 years, 1 month ago by Kevin Millikin (Google)
Modified:
4 years, 1 month ago
Reviewers:
jensj
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support both older and newer implementations of dart:async. The VM target's continuation transformer uses a class that was originally named _StreamIteratorImpl and then renamed to _StreamIterator. If looking up the old name fails, try the new name. BUG= R=jensj@google.com Committed: https://github.com/dart-lang/kernel/commit/480abf7604fd64b96bd4b974352db034179f413a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M lib/transformations/continuation.dart View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
4 years, 1 month ago (2016-11-02 08:14:53 UTC) #2
jensj
lgtm, though it might seem reasonable to look for the new name first and then ...
4 years, 1 month ago (2016-11-02 08:22:43 UTC) #3
Kevin Millikin (Google)
4 years, 1 month ago (2016-11-02 08:32:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
480abf7604fd64b96bd4b974352db034179f413a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698