Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1582)

Issue 2465163003: Re-enable AppBannerManagerBrowserTest.WebAppBannerCreatedIndirectMultipleLargerTotal. (Closed)

Created:
4 years, 1 month ago by dominickn
Modified:
4 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable AppBannerManagerBrowserTest.WebAppBannerCreatedIndirectMultipleLargerTotal. The failures don't reproduce locally - re-enabling to see if that sticks. BUG=660798 TBR=benwells@chromium.org Committed: https://crrev.com/59a0f926eee47b951754598ac77dda4a5bbafcde Cr-Commit-Position: refs/heads/master@{#429191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M chrome/browser/banners/app_banner_manager_browsertest.cc View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465163003/1
4 years, 1 month ago (2016-11-02 02:46:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 02:50:25 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/59a0f926eee47b951754598ac77dda4a5bbafcde Cr-Commit-Position: refs/heads/master@{#429191}
4 years, 1 month ago (2016-11-02 02:51:56 UTC) #9
jam
4 years, 1 month ago (2016-11-03 14:29:27 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2471843004/ by jam@chromium.org.

The reason for reverting is: This is causing a lot of try bot flakes

Please don't renable without fixing.

See
http://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9t....

Powered by Google App Engine
This is Rietveld 408576698