Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 246513003: Add missing ui unit test targets to chromium_trybot.json. (Closed)

Created:
6 years, 8 months ago by tfarina
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add missing ui unit test targets to chromium_trybot.json. BUG=365712 TEST=green trybots R=phajdan.jr@chromium.org,sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265939

Patch Set 1 #

Patch Set 2 : exclude keyboard_unittests from mac_chromium_rel #

Patch Set 3 : exclude it from mac_chromium_compile_dbg too #

Patch Set 4 : make events_unittests depend on gfx_test_support #

Patch Set 5 : remove trailing comma #

Patch Set 6 : add gfx_geometry back #

Total comments: 2

Patch Set 7 : using platforms instead #

Patch Set 8 : remove trailing comma - looks like chromium_factory.py does not like it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M testing/buildbot/chromium_trybot.json View 1 2 3 4 5 6 7 3 chunks +6 lines, -0 lines 0 comments Download
M ui/events/events.gyp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
It should be good now. PTAL.
6 years, 8 months ago (2014-04-22 16:07:51 UTC) #1
sadrul
LGTM. Thanks a lot for taking care of this!
6 years, 8 months ago (2014-04-22 17:38:28 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/246513003/diff/80001/testing/buildbot/chromium_trybot.json File testing/buildbot/chromium_trybot.json (right): https://codereview.chromium.org/246513003/diff/80001/testing/buildbot/chromium_trybot.json#newcode30 testing/buildbot/chromium_trybot.json:30: "exclude_builders": [ Why not "platforms": ["linux", "win"] instead? There ...
6 years, 8 months ago (2014-04-23 10:42:13 UTC) #3
tfarina
https://codereview.chromium.org/246513003/diff/80001/testing/buildbot/chromium_trybot.json File testing/buildbot/chromium_trybot.json (right): https://codereview.chromium.org/246513003/diff/80001/testing/buildbot/chromium_trybot.json#newcode30 testing/buildbot/chromium_trybot.json:30: "exclude_builders": [ On 2014/04/23 10:42:13, Paweł Hajdan Jr. wrote: ...
6 years, 8 months ago (2014-04-23 13:03:26 UTC) #4
Paweł Hajdan Jr.
LGTM
6 years, 8 months ago (2014-04-24 11:00:38 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-24 13:16:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/246513003/140001
6 years, 8 months ago (2014-04-24 13:45:32 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 15:09:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 15:09:06 UTC) #9
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-24 15:55:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/246513003/140001
6 years, 8 months ago (2014-04-24 15:55:29 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 16:42:05 UTC) #12
Message was sent while issue was closed. 
Change committed as 265939

Powered by Google App Engine
This is Rietveld 408576698