Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 246513002: eliminate config param -- it was always self's config (Closed)

Created:
6 years, 8 months ago by reed1
Modified:
6 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

eliminate config param -- it was always self's config BUG=skia: R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=14303

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -26 lines) Patch
M include/core/SkPixelRef.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/gpu/SkGrPixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 3 chunks +8 lines, -18 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
this change both simplifies, and will enable us to deepCopy RGBA and BGRA. Today we ...
6 years, 8 months ago (2014-04-22 03:04:54 UTC) #1
reed1
ptal
6 years, 8 months ago (2014-04-22 17:48:36 UTC) #2
bsalomon
lgtm
6 years, 8 months ago (2014-04-22 17:52:28 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 8 months ago (2014-04-22 18:12:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/246513002/1
6 years, 8 months ago (2014-04-22 18:13:04 UTC) #5
reed1
The CQ bit was checked by reed@google.com
6 years, 8 months ago (2014-04-22 18:20:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/246513002/20001
6 years, 8 months ago (2014-04-22 18:21:06 UTC) #7
reed1
The CQ bit was unchecked by reed@google.com
6 years, 8 months ago (2014-04-22 18:21:16 UTC) #8
reed1
Committed patchset #2 manually as r14303 (presubmit successful).
6 years, 8 months ago (2014-04-22 18:23:28 UTC) #9
bsalomon
6 years, 8 months ago (2014-04-23 14:51:42 UTC) #10
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/249373003/ by bsalomon@google.com.

The reason for reverting is: Causes some layout_test failures around texture
backed bitmaps. Test names and crash logs accessible via:
https://storage.googleapis.com/chromium-layout-test-archives/linux_layout/138...

.

Powered by Google App Engine
This is Rietveld 408576698