Add a dummy entry with libsecret when initializing OSCrypt.

Add a dummy entry with libsecret when initializing OSCrypt.

Under certain conditions, gnome libsecret methods that perform a lookup
in keyring may ignore a locked keyring and return empty results, instead
of unlocking said keyring. Store operations are unaffected by this quirk
(or bug, presumably).

With this change, we store a dummy entry during the initialisation of
OSCrypt. This ensures that the default keyring gets unlocked and is
available for future reads.

This solution is also applied to Password Manager, before performing
calls to secret_service_search_sync.

This solution should be temporary, until the underlying issue gets fixed
or there is an official workaround.

BUG=660005, 631171
Review-Url: https://codereview.chromium.org/2461453002
Cr-Commit-Position: refs/heads/master@{#428378}

NOTRY=true
NOPRESUBMIT=true

[Tom (Use chromium acct), 2016-10-31 23:57:58]

Description was changed from

==========
Add a dummy entry with libsecret when initializing OSCrypt.

Under certain conditions, gnome libsecret methods that perform a lookup
in keyring may ignore a locked keyring and return empty results, instead
of unlocking said keyring. Store operations are unaffected by this quirk
(or bug, presumably).

With this change, we store a dummy entry during the initialisation of
OSCrypt. This ensures that the default keyring gets unlocked and is
available for future reads.

This solution is also applied to Password Manager, before performing
calls to secret_service_search_sync.

This solution should be temporary, until the underlying issue gets fixed
or there is an official workaround.

BUG=660005,631171

Review-Url: https://codereview.chromium.org/2461453002
Cr-Commit-Position: refs/heads/master@{#428378}
==========

to

==========
Add a dummy entry with libsecret when initializing OSCrypt.

Under certain conditions, gnome libsecret methods that perform a lookup
in keyring may ignore a locked keyring and return empty results, instead
of unlocking said keyring. Store operations are unaffected by this quirk
(or bug, presumably).

With this change, we store a dummy entry during the initialisation of
OSCrypt. This ensures that the default keyring gets unlocked and is
available for future reads.

This solution is also applied to Password Manager, before performing
calls to secret_service_search_sync.

This solution should be temporary, until the underlying issue gets fixed
or there is an official workaround.

BUG=660005,631171

Review-Url: https://codereview.chromium.org/2461453002
Cr-Commit-Position: refs/heads/master@{#428378}

NOTRY=true
NOPRESUBMIT=true
==========

[Tom Anderson, 2016-11-01 00:02:38]

thomasanderson@chromium.org changed reviewers:
+ thomasanderson@chromium.org

[Tom Anderson, 2016-11-01 00:02:39]

lgtm from my @chromium account

[Tom Anderson, 2016-11-01 00:03:07]

The CQ bit was checked by thomasanderson@chromium.org

[commit-bot: I haz the power, 2016-11-01 00:03:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 00:03:38]

This CL has an open dependency (Issue 2463263002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Tom Anderson, 2016-11-01 00:09:22]

The CQ bit was checked by thomasanderson@chromium.org

[commit-bot: I haz the power, 2016-11-01 00:09:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 00:14:01]

Description was changed from

==========
Add a dummy entry with libsecret when initializing OSCrypt.

Under certain conditions, gnome libsecret methods that perform a lookup
in keyring may ignore a locked keyring and return empty results, instead
of unlocking said keyring. Store operations are unaffected by this quirk
(or bug, presumably).

With this change, we store a dummy entry during the initialisation of
OSCrypt. This ensures that the default keyring gets unlocked and is
available for future reads.

This solution is also applied to Password Manager, before performing
calls to secret_service_search_sync.

This solution should be temporary, until the underlying issue gets fixed
or there is an official workaround.

BUG=660005,631171

Review-Url: https://codereview.chromium.org/2461453002
Cr-Commit-Position: refs/heads/master@{#428378}

NOTRY=true
NOPRESUBMIT=true
==========

to

==========
Add a dummy entry with libsecret when initializing OSCrypt.

Under certain conditions, gnome libsecret methods that perform a lookup
in keyring may ignore a locked keyring and return empty results, instead
of unlocking said keyring. Store operations are unaffected by this quirk
(or bug, presumably).

With this change, we store a dummy entry during the initialisation of
OSCrypt. This ensures that the default keyring gets unlocked and is
available for future reads.

This solution is also applied to Password Manager, before performing
calls to secret_service_search_sync.

This solution should be temporary, until the underlying issue gets fixed
or there is an official workaround.

BUG=660005,631171

Review-Url: https://codereview.chromium.org/2461453002
Cr-Commit-Position: refs/heads/master@{#428378}

NOTRY=true
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-11-01 00:14:02]

Committed patchset #1 (id:1)