Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2465053002: Asserting screen is on for all content shell tests (Closed)

Created:
4 years, 1 month ago by amaralp
Modified:
4 years, 1 month ago
CC:
bpastene, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, yabinh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Asserting screen is on for all content shell tests Many ContentShellTests will fail if the screen is not on. This assert helps diagnose those failures. BUG=659869 Committed: https://crrev.com/73584a85ececf0f877630c158fb90f1fa7a2cdc3 Cr-Commit-Position: refs/heads/master@{#429061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 3 chunks +0 lines, -18 lines 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
amaralp
PTAL
4 years, 1 month ago (2016-10-31 21:32:36 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-10-31 21:42:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2465053002/1
4 years, 1 month ago (2016-11-01 18:28:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 18:35:04 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 18:54:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73584a85ececf0f877630c158fb90f1fa7a2cdc3
Cr-Commit-Position: refs/heads/master@{#429061}

Powered by Google App Engine
This is Rietveld 408576698