Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: chrome/browser/mod_pagespeed/mod_pagespeed_metrics_unittest.cc

Issue 2465023002: Make SVN commit number an optional part of X-Mod-Pagespeed header. (Closed)
Patch Set: Add mod_pagespeed/OWNERS file. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/mod_pagespeed/mod_pagespeed_metrics.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/mod_pagespeed/mod_pagespeed_metrics_unittest.cc
diff --git a/chrome/browser/mod_pagespeed/mod_pagespeed_metrics_unittest.cc b/chrome/browser/mod_pagespeed/mod_pagespeed_metrics_unittest.cc
index f7ccb925b3104e049478f214dc49bf9ac6a8e312..b373b22b9eab32bd2281cef030000253e8a64174 100644
--- a/chrome/browser/mod_pagespeed/mod_pagespeed_metrics_unittest.cc
+++ b/chrome/browser/mod_pagespeed/mod_pagespeed_metrics_unittest.cc
@@ -75,6 +75,22 @@ TEST(ModPagespeedMetricsTest, CountPageSpeedHeadersTest) {
EXPECT_EQ(num_bucket_33, version_samples->GetCount(33));
headers->RemoveHeader("X-Mod-Pagespeed");
+ // X-Mod-Pagespeed header in expected format, without (optional) SVN commit
+ // number.
+ headers->AddHeader("X-Mod-Pagespeed: 1.2.24.1");
+ RecordMetrics(content::RESOURCE_TYPE_MAIN_FRAME, url, headers.get());
+ server_samples = server_histogram->SnapshotSamples();
+ version_samples = version_histogram->SnapshotSamples();
+ EXPECT_EQ(++num_responses, server_samples->GetCount(0));
+ EXPECT_EQ(++num_mps, server_samples->GetCount(1));
+ EXPECT_EQ(num_ngx, server_samples->GetCount(2));
+ EXPECT_EQ(num_pss, server_samples->GetCount(3));
+ EXPECT_EQ(num_other, server_samples->GetCount(4));
+ EXPECT_EQ(num_bucket_1, version_samples->GetCount(1));
+ EXPECT_EQ(++num_bucket_30, version_samples->GetCount(30)); // +1 for #30
+ EXPECT_EQ(num_bucket_33, version_samples->GetCount(33));
+ headers->RemoveHeader("X-Mod-Pagespeed");
+
// X-Mod-Pagespeed header in unexpected format.
headers->AddHeader("X-Mod-Pagespeed: Powered By PageSpeed!");
RecordMetrics(content::RESOURCE_TYPE_MAIN_FRAME, url, headers.get());
« no previous file with comments | « chrome/browser/mod_pagespeed/mod_pagespeed_metrics.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698