Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2464973003: DevTools: Add test for Runtime Stats present on timeline. (Closed)

Created:
4 years, 1 month ago by alph
Modified:
4 years, 1 month ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add test for Runtime Stats present on timeline. BUG=660428 Committed: https://crrev.com/42b34a035f6d9c4de758f0445324f5f371776ae4 Cr-Commit-Position: refs/heads/master@{#428914}

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressing comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-runtime-stats.html View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-runtime-stats-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
alph
4 years, 1 month ago (2016-11-01 00:59:22 UTC) #2
caseq
lgtm https://codereview.chromium.org/2464973003/diff/1/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-runtime-stats.html File third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-runtime-stats.html (right): https://codereview.chromium.org/2464973003/diff/1/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-runtime-stats.html#newcode11 third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-runtime-stats.html:11: return Promise.resolve(div.offsetWidth); make it sync, remove the promise. ...
4 years, 1 month ago (2016-11-01 01:09:01 UTC) #3
alph
https://codereview.chromium.org/2464973003/diff/1/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-runtime-stats.html File third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-runtime-stats.html (right): https://codereview.chromium.org/2464973003/diff/1/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-runtime-stats.html#newcode11 third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-runtime-stats.html:11: return Promise.resolve(div.offsetWidth); On 2016/11/01 01:09:00, caseq wrote: > make ...
4 years, 1 month ago (2016-11-01 01:13:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464973003/20001
4 years, 1 month ago (2016-11-01 01:14:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-01 02:19:22 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 02:21:01 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/42b34a035f6d9c4de758f0445324f5f371776ae4
Cr-Commit-Position: refs/heads/master@{#428914}

Powered by Google App Engine
This is Rietveld 408576698