Use FFmpeg default padding when allocating audio buffers.

Use FFmpeg default padding when allocating audio buffers.

Previously, we would pad to the alignment size when allocating an
audio buffer.  However, this did not always provide enough padding
to avoid overruns.

Instead, we now let FFmpeg determine the correct padding for us.

BUG=658440
Committed: https://crrev.com/b8733772baf52a693ab6a887373feaa6b91c7cdd
Cr-Commit-Position: refs/heads/master@{#429014}

[liberato (no reviews please), 2016-10-31 20:30:38]

The CQ bit was checked by liberato@chromium.org to run a CQ dry run

[liberato (no reviews please), 2016-10-31 20:31:02]

Description was changed from

==========
Use FFmpeg default padding when allocating audio buffers.

Previously, we would pad to the alignment size when allocating an
audio buffer.  However, this did not always provide enough padding
to avoid overruns.

Instead, we now let FFmpeg determine the correct padding for us.

BUG=658440
==========

to

==========
Use FFmpeg default padding when allocating audio buffers.

Previously, we would pad to the alignment size when allocating an
audio buffer.  However, this did not always provide enough padding
to avoid overruns.

Instead, we now let FFmpeg determine the correct padding for us.

BUG=658440
==========

[liberato (no reviews please), 2016-10-31 20:31:02]

liberato@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[commit-bot: I haz the power, 2016-10-31 20:31:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2016-10-31 21:06:31]

Can you add a ffmpeg_regression_test with this test case in it?

[commit-bot: I haz the power, 2016-10-31 23:59:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 23:59:29]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2016-11-01 16:05:44]

Whoops thought I lgtm'd this to land as is. Test can be added separately

[liberato (no reviews please), 2016-11-01 16:18:22]

On 2016/11/01 16:05:44, DaleCurtis wrote:
> Whoops thought I lgtm'd this to land as is. Test can be added separately

cool, since the test is going badly :)

first, it fails two test expectations.  one is a bug in the test harness. 
OnDurationChanged is called twice, rather than the expected at most once, since
the media duration isn't known in advance.

there's also an expectation failure when seeking.  the media time isn't being
set properly to the seek point, and i'm trying to figure out why.

oh, and the asan failure doesn't repro in the test anyway, since it needs to be
run twice.  not sure why yet -- certainly doesn't bode well for a good repro. 
adding two identical test cases does cause it, but not sure what's
re-kershuffling the data around in memory yet.

[liberato (no reviews please), 2016-11-01 16:18:27]

The CQ bit was checked by liberato@chromium.org

[commit-bot: I haz the power, 2016-11-01 16:18:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 16:23:27]

Description was changed from

==========
Use FFmpeg default padding when allocating audio buffers.

Previously, we would pad to the alignment size when allocating an
audio buffer.  However, this did not always provide enough padding
to avoid overruns.

Instead, we now let FFmpeg determine the correct padding for us.

BUG=658440
==========

to

==========
Use FFmpeg default padding when allocating audio buffers.

Previously, we would pad to the alignment size when allocating an
audio buffer.  However, this did not always provide enough padding
to avoid overruns.

Instead, we now let FFmpeg determine the correct padding for us.

BUG=658440
==========

[commit-bot: I haz the power, 2016-11-01 16:23:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-01 17:22:12]

Description was changed from

==========
Use FFmpeg default padding when allocating audio buffers.

Previously, we would pad to the alignment size when allocating an
audio buffer.  However, this did not always provide enough padding
to avoid overruns.

Instead, we now let FFmpeg determine the correct padding for us.

BUG=658440
==========

to

==========
Use FFmpeg default padding when allocating audio buffers.

Previously, we would pad to the alignment size when allocating an
audio buffer.  However, this did not always provide enough padding
to avoid overruns.

Instead, we now let FFmpeg determine the correct padding for us.

BUG=658440

Committed: https://crrev.com/b8733772baf52a693ab6a887373feaa6b91c7cdd
Cr-Commit-Position: refs/heads/master@{#429014}
==========

[commit-bot: I haz the power, 2016-11-01 17:22:13]

Patchset 1 (id:??) landed as
https://crrev.com/b8733772baf52a693ab6a887373feaa6b91c7cdd
Cr-Commit-Position: refs/heads/master@{#429014}