Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2464953002: Add support for OSR in kernel-based FlowGraphBuilder (Closed)

Created:
4 years, 1 month ago by kustermann
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
kustermann
4 years, 1 month ago (2016-10-31 17:40:47 UTC) #2
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/2464953002/diff/1/runtime/vm/kernel_to_il.cc File runtime/vm/kernel_to_il.cc (right): https://codereview.chromium.org/2464953002/diff/1/runtime/vm/kernel_to_il.cc#newcode2933 runtime/vm/kernel_to_il.cc:2933: PruneUnreachableIfOSR(); I think only this one can OSR ...
4 years, 1 month ago (2016-10-31 17:46:37 UTC) #3
kustermann
Committed patchset #2 (id:40001) manually as e984271b94de3d4a72d52a3722e8ffb58da25dde (presubmit successful).
4 years, 1 month ago (2016-10-31 18:12:18 UTC) #6
kustermann
4 years, 1 month ago (2016-10-31 18:18:13 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2464953002/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2464953002/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:2933: PruneUnreachableIfOSR();
On 2016/10/31 17:46:37, Vyacheslav Egorov (Google) wrote:
> I think  only this one can OSR - inline the function here.

Done.

https://codereview.chromium.org/2464953002/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:3143: PruneUnreachableIfOSR();
On 2016/10/31 17:46:37, Vyacheslav Egorov (Google) wrote:
> I don't think this and below can be OSRed.

Done.

Powered by Google App Engine
This is Rietveld 408576698