Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2464903002: Add missing sk_tool_utils flags_common dependency (Closed)

Created:
4 years, 1 month ago by f(malita)
Modified:
4 years, 1 month ago
Reviewers:
mtklein, mtklein_C
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add missing sk_tool_utils flags_common dependency Not sure why this is only a problem on my workstation, but SampleApp linking is borked with obj/gyp/../tools/sk_tool_utils.sk_tool_utils.o: In function `sk_tool_utils::platform_os_name()': /mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:128: undefined reference to `FLAGS_key' /mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:129: undefined reference to `FLAGS_key' /mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:127: undefined reference to `FLAGS_key' obj/gyp/../tools/sk_tool_utils.sk_tool_utils.o: In function `sk_tool_utils::major_platform_os_name()': /mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:140: undefined reference to `FLAGS_key' /mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:141: undefined reference to `FLAGS_key' obj/gyp/../tools/sk_tool_utils.sk_tool_utils.o:/mnt/screamin/src/blink/src/third_party/skia/out/Debug/../../tools/sk_tool_utils.cpp:139: more undefined references to `FLAGS_key' follow collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. R=mtklein@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2464903002 Committed: https://skia.googlesource.com/skia/+/fb4b9a27a1a0267e44aa4c8766322e53a06d3c37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/tools.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
f(malita)
4 years, 1 month ago (2016-10-31 14:03:13 UTC) #4
mtklein_C
lgtm I think it's just that people immediately started ignoring SampleApp in GYP once SampleApp ...
4 years, 1 month ago (2016-10-31 14:12:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2464903002/1
4 years, 1 month ago (2016-10-31 14:13:20 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 14:22:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fb4b9a27a1a0267e44aa4c8766322e53a06d3c37

Powered by Google App Engine
This is Rietveld 408576698