Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue

Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue

We suspect a bad task closure is getting posted and would like to
add crash keys to aid diagnosis.

BUG=660427, 661927
Committed: https://crrev.com/c08c078b27b353f4ab8de7deccfb862270b1ff2a
Cr-Commit-Position: refs/heads/master@{#429285}

[alex clarke (OOO till 29th), 2016-10-31 13:11:27]

alexclarke@chromium.org changed reviewers:
+ rsesek@chromium.org, skyostil@chromium.org

[alex clarke (OOO till 29th), 2016-10-31 13:11:28]

Please take a look.

[alex clarke (OOO till 29th), 2016-10-31 13:11:35]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 13:11:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 13:24:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 13:24:12]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Robert Sesek, 2016-10-31 14:32:32]

https://codereview.chromium.org/2464853002/diff/1/chrome/common/crash_keys.cc
File chrome/common/crash_keys.cc (left):

https://codereview.chromium.org/2464853002/diff/1/chrome/common/crash_keys.cc...
chrome/common/crash_keys.cc:105: { kMetricsClientId, kSmallSize },
Please leave this formatted as-is. It makes the diff harder to grok than
necessary.

https://codereview.chromium.org/2464853002/diff/1/chrome/common/crash_keys.cc
File chrome/common/crash_keys.cc (right):

https://codereview.chromium.org/2464853002/diff/1/chrome/common/crash_keys.cc...
chrome/common/crash_keys.cc:104: // 1.
//blimp/engine/app/blimp_engine_crash_keys.cc and
Please add to this file too.

[alex clarke (OOO till 29th), 2016-10-31 15:51:10]

PTAL

https://codereview.chromium.org/2464853002/diff/1/chrome/common/crash_keys.cc
File chrome/common/crash_keys.cc (left):

https://codereview.chromium.org/2464853002/diff/1/chrome/common/crash_keys.cc...
chrome/common/crash_keys.cc:105: { kMetricsClientId, kSmallSize },
On 2016/10/31 14:32:32, Robert Sesek wrote:
> Please leave this formatted as-is. It makes the diff harder to grok than
> necessary.

Sorry that's what git cl format did.  I'll revert.

https://codereview.chromium.org/2464853002/diff/1/chrome/common/crash_keys.cc
File chrome/common/crash_keys.cc (right):

https://codereview.chromium.org/2464853002/diff/1/chrome/common/crash_keys.cc...
chrome/common/crash_keys.cc:104: // 1.
//blimp/engine/app/blimp_engine_crash_keys.cc and
On 2016/10/31 14:32:32, Robert Sesek wrote:
> Please add to this file too.

Done.

[alex clarke (OOO till 29th), 2016-10-31 15:51:55]

alexclarke@chromium.org changed reviewers:
+ ananta@chromium.org

[alex clarke (OOO till 29th), 2016-10-31 15:51:58]

ananta@chromium.org: Please review changes in
chrome_crash_reporter_client_win.cc

[Sami, 2016-10-31 16:01:53]

scheduler/ lgtm.

https://codereview.chromium.org/2464853002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
(right):

https://codereview.chromium.org/2464853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:321:
CHECK(!pending_task.task.is_null()) << "Posted from "
Could you also mention here:

// Temporary for https://crbug.com/660427

[alex clarke (OOO till 29th), 2016-10-31 16:09:33]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 16:09:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 16:26:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 16:26:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alex clarke (OOO till 29th), 2016-10-31 16:36:03]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 16:36:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2016-10-31 16:45:49]

LGTM

[commit-bot: I haz the power, 2016-10-31 17:52:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 17:52:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alex clarke (OOO till 29th), 2016-11-01 10:37:25]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 10:37:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 10:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 10:46:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alex clarke (OOO till 29th), 2016-11-01 10:52:44]

Patchset #5 (id:80001) has been deleted

[alex clarke (OOO till 29th), 2016-11-01 10:54:27]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 10:54:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 11:03:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 11:03:37]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[alex clarke (OOO till 29th), 2016-11-01 11:06:04]

Patchset #5 (id:100001) has been deleted

[alex clarke (OOO till 29th), 2016-11-01 11:07:55]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 11:08:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 12:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 12:50:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alex clarke (OOO till 29th), 2016-11-01 13:27:43]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 13:28:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 14:52:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 14:53:00]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alex clarke (OOO till 29th), 2016-11-01 16:19:59]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 16:20:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2016-11-01 17:40:24]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 17:41:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 19:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 19:15:44]

Dry run: This issue passed the CQ dry run.

[alex clarke (OOO till 29th), 2016-11-01 21:55:21]

alexclarke@chromium.org changed reviewers:
+ scottmg@chromium.org

[alex clarke (OOO till 29th), 2016-11-01 21:55:22]

+scottmg@

https://codereview.chromium.org/2464853002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
(right):

https://codereview.chromium.org/2464853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:321:
CHECK(!pending_task.task.is_null()) << "Posted from "
On 2016/10/31 16:01:53, Sami wrote:
> Could you also mention here:
> 
> // Temporary for https://crbug.com/660427

Done.

[scottmg, 2016-11-01 21:58:57]

chrome/app/chrome_crash_reporter_client_win.cc lgtm

(please say what file you want an owner to look at when +'d in late in review)

https://codereview.chromium.org/2464853002/diff/180001/chrome/app/chrome_cras...
File chrome/app/chrome_crash_reporter_client_win.cc (right):

https://codereview.chromium.org/2464853002/diff/180001/chrome/app/chrome_cras...
chrome/app/chrome_crash_reporter_client_win.cc:199: // Temporary for
https://crbug.com/660427
nit; Trailing . on comments.

[alex clarke (OOO till 29th), 2016-11-02 13:41:25]

On 2016/11/01 21:58:57, scottmg wrote:
> chrome/app/chrome_crash_reporter_client_win.cc lgtm
> 
> (please say what file you want an owner to look at when +'d in late in review)

Noted.

> 
>
https://codereview.chromium.org/2464853002/diff/180001/chrome/app/chrome_cras...
> File chrome/app/chrome_crash_reporter_client_win.cc (right):
> 
>
https://codereview.chromium.org/2464853002/diff/180001/chrome/app/chrome_cras...
> chrome/app/chrome_crash_reporter_client_win.cc:199: // Temporary for
> https://crbug.com/660427
> nit; Trailing . on comments.

Thanks for the review.

[alex clarke (OOO till 29th), 2016-11-02 13:41:36]

https://codereview.chromium.org/2464853002/diff/180001/chrome/app/chrome_cras...
File chrome/app/chrome_crash_reporter_client_win.cc (right):

https://codereview.chromium.org/2464853002/diff/180001/chrome/app/chrome_cras...
chrome/app/chrome_crash_reporter_client_win.cc:199: // Temporary for
https://crbug.com/660427
On 2016/11/01 21:58:57, scottmg wrote:
> nit; Trailing . on comments.

Done.

[alex clarke (OOO till 29th), 2016-11-02 13:41:43]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-11-02 13:41:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org, rsesek@chromium.org, scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2464853002/#ps200001
(title: "Added missing periods")

[commit-bot: I haz the power, 2016-11-02 13:42:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 15:47:45]

Committed patchset #9 (id:200001)

[commit-bot: I haz the power, 2016-11-02 15:50:35]

Description was changed from

==========
Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue

We suspect a bad task closure is getting posted and would like to
add crash keys to aid diagnosis.

BUG=660427
==========

to

==========
Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue

We suspect a bad task closure is getting posted and would like to
add crash keys to aid diagnosis.

BUG=660427

Committed: https://crrev.com/c08c078b27b353f4ab8de7deccfb862270b1ff2a
Cr-Commit-Position: refs/heads/master@{#429285}
==========

[commit-bot: I haz the power, 2016-11-02 15:50:36]

Patchset 9 (id:??) landed as
https://crrev.com/c08c078b27b353f4ab8de7deccfb862270b1ff2a
Cr-Commit-Position: refs/heads/master@{#429285}

[alex clarke (OOO till 29th), 2016-11-11 10:30:59]

Description was changed from

==========
Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue

We suspect a bad task closure is getting posted and would like to
add crash keys to aid diagnosis.

BUG=660427

Committed: https://crrev.com/c08c078b27b353f4ab8de7deccfb862270b1ff2a
Cr-Commit-Position: refs/heads/master@{#429285}
==========

to

==========
Add crash keys to TaskQueueManager::ProcessTaskFromWorkQueue

We suspect a bad task closure is getting posted and would like to
add crash keys to aid diagnosis.

BUG=660427, 661927

Committed: https://crrev.com/c08c078b27b353f4ab8de7deccfb862270b1ff2a
Cr-Commit-Position: refs/heads/master@{#429285}
==========

[alex clarke (OOO till 29th), 2016-11-11 10:32:33]

A revert of this CL (patchset #9 id:200001) has been created in
https://codereview.chromium.org/2486673007/ by alexclarke@chromium.org.

The reason for reverting is: Long term I'd like to reland this, after the perf
regression has been sorted out. Data from this helped fix a number of bugs.

https://bugs.chromium.org/p/chromium/issues/detail?id=661927&can=8&q=24648530...

.