Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2464843002: Fix some strong mode issues. (Closed)

Created:
4 years, 1 month ago by asgerf
Modified:
4 years, 1 month ago
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Revert .analysis_options as there are still strong-mode issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -95 lines) Patch
M lib/analyzer/ast_from_analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/checks.dart View 3 chunks +2 lines, -83 lines 0 comments Download
M lib/text/ast_to_text.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M lib/transformations/mixin_full_resolution.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/type_algebra.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/class_hierarchy_basic.dart View 1 chunk +1 line, -2 lines 0 comments Download
M test/class_hierarchy_tester.dart View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
asgerf
4 years, 1 month ago (2016-10-31 13:01:56 UTC) #2
Kevin Millikin (Google)
LGTM.
4 years, 1 month ago (2016-10-31 15:10:55 UTC) #4
asgerf
4 years, 1 month ago (2016-11-14 09:23:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
73463488ee70a054df0d7b19d38e2847f471fac7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698