Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2464833002: Fix Debian builder. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
Reviewers:
zra, Bill Hesse, kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Debian builder. Do not rely on checked in Dart SDK for patch_sdk.py. Use dart_boostrap instead just like observatory does. R=kustermann@google.com, whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2cd737ababc68262362567ad3df5144c4bdcf701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M runtime/vm/vm.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/patch_sdk.py View 1 chunk +16 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-10-31 12:44:13 UTC) #1
kustermann
lgtm
4 years, 1 month ago (2016-10-31 13:08:47 UTC) #3
Vyacheslav Egorov (Google)
Committed patchset #1 (id:1) manually as 2cd737ababc68262362567ad3df5144c4bdcf701 (presubmit successful).
4 years, 1 month ago (2016-10-31 13:13:37 UTC) #5
Bill Hesse
lgtm
4 years, 1 month ago (2016-10-31 13:34:42 UTC) #6
zra
4 years, 1 month ago (2016-10-31 18:05:47 UTC) #8
Message was sent while issue was closed.
DBC

Please update the GN build.

Powered by Google App Engine
This is Rietveld 408576698