Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h

Issue 2464823003: Refactor LayoutView paint offset updates out of FrameView update code (Closed)
Patch Set: Incorporate Tien-Ren's review ideas Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
index 94ed99e5e512597f73a00bc66d4466ed8c6b9a83..cf69a0689f7990592c4982cb3684052264f2fcce 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
@@ -16,6 +16,7 @@ namespace blink {
class FrameView;
class LayoutObject;
+class LayoutView;
// The context for PaintPropertyTreeBuilder.
// It's responsible for bookkeeping tree state in other order, for example, the
@@ -84,7 +85,8 @@ class PaintPropertyTreeBuilder {
PaintPropertyTreeBuilderContext setupInitialContext();
// Update the paint properties for |FrameView| and ensure the context is
// up to date.
- void updatePropertiesAndContext(FrameView&, PaintPropertyTreeBuilderContext&);
+ void updateFramePropertiesAndContext(FrameView&,
+ PaintPropertyTreeBuilderContext&);
// Update the paint properties that affect this object (e.g., properties like
// paint offset translation) and ensure the context is up to date.
@@ -96,6 +98,9 @@ class PaintPropertyTreeBuilder {
PaintPropertyTreeBuilderContext&);
private:
+ static void updateLayoutViewPaintOffsetTranslation(
+ const LayoutView&,
+ PaintPropertyTreeBuilderContext&);
static void updatePaintOffsetTranslation(const LayoutObject&,
PaintPropertyTreeBuilderContext&);
static void updateTransform(const LayoutObject&,

Powered by Google App Engine
This is Rietveld 408576698