Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java |
| index 72178f656d1a22448f067591e36f08b6b4caec98..dc0aba6fe97ae1de063a13886dbb18c8d9fa732a 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java |
| @@ -241,8 +241,13 @@ public class MinidumpUploadService extends IntentService { |
| minidumpUploadCallable.call(); |
| if (uploadStatus == MinidumpUploadCallable.UPLOAD_SUCCESS) { |
| + CrashFileManager.markUploadSuccess(minidumpFile); |
| // Only update UMA stats if an intended and successful upload. |
|
Ilya Sherman
2016/10/31 19:48:13
I'm a bit confused by this comment. Do you know w
gsennton
2016/10/31 19:54:30
IIUC we only have UMA stats for successful uploads
|
| incrementCrashSuccessUploadCount(getNewNameAfterSuccessfulUpload(minidumpFileName)); |
| + } else if (uploadStatus == MinidumpUploadCallable.UPLOAD_USER_DISABLED |
| + || uploadStatus == MinidumpUploadCallable.UPLOAD_DISABLED_BY_SAMPLING) { |
| + Log.i(TAG, "Marking minidump as skipped for cleanup to prevent future uploads."); |
| + CrashFileManager.markUploadSkipped(minidumpFile); |
| } else if (uploadStatus == MinidumpUploadCallable.UPLOAD_FAILURE) { |
| // Unable to upload minidump. Incrementing try number and restarting. |